Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reporting updates and fixes #300

Merged
merged 4 commits into from
Jul 19, 2022
Merged

chore: reporting updates and fixes #300

merged 4 commits into from
Jul 19, 2022

Conversation

brownoxford
Copy link
Collaborator

  • Update size of boxes in facet report to prevent overlapping
  • Color pass/fail based on number of assertions passed or failed
  • Clean up tooltips on facet report

FIX: #278

@brownoxford
docs: update scatter plot size to prevent overlaps
ec61359
@brownoxford
fix: multiple assertions are properly processed
9a9b24e 
Ensure that multiple assertions are properly accounted for in each test instead of randomly selecting one assertion result to display.
@brownoxford
chore: clean up tooltips
d068f3b
OR13
OR13 requested changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about adding "partial" to the test report.

Need additional details to approve / deny.

defaulting to deny.

@mprorock
Copy link
Collaborator

Unsure about adding "partial" to the test report.

Need additional details to approve / deny.

defaulting to deny.

I definitely lean this way as well

@OR13 OR13 self-requested a review July 15, 2022 22:23
OR13
OR13 requested changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change "Partial" to "Fail-partial", colors are good to keep as is.

mprorock
mprorock requested changes Jul 16, 2022
View reviewed changes
Copy link
Collaborator

@mprorock mprorock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see minor adjustments I suggested @brownoxford @OR13

@brownoxford
chore: modify text indicating partial failure
36855a0 
Also clean up minor debug and incorrect column name.
@brownoxford
Copy link
Collaborator Author

brownoxford commented Jul 16, 2022 •
edited
Loading

I modified the text used in the status column for partial failures to be Fail (Partial) and fixed a column name typo in getFacet().

We can also play around with the text in the hover popup, e.g., stop showing shape and size, start showing Passing: x/y, etc. (I mention this because the overlay is the only place where the Fail (Partial) text is visible.)

@OR13 OR13 self-requested a review July 18, 2022 13:29
@brownoxford
Copy link
Collaborator Author

Here are some screenshots that show how reports will now look:

Screen Shot 2022-07-19 at 12 47 03 PM
Screen Shot 2022-07-19 at 12 47 30 PM
Screen Shot 2022-07-19 at 12 47 38 PM

@nissimsan nissimsan merged commit 62aa7be into main Jul 19, 2022
@brownoxford brownoxford deleted the reporting-fixes branch July 19, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mprorock mprorock mprorock approved these changes

@OR13 OR13 OR13 approved these changes

@mkhraisha mkhraisha mkhraisha approved these changes

@nissimsan nissimsan nissimsan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interactive report graphs "don't look right"
5 participants
@brownoxford @mprorock @OR13 @mkhraisha @nissimsan