Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all type array of string(s) #445

Closed
BenjaminMoe opened this issue Jun 14, 2022 · 4 comments
Closed

Make all type array of string(s) #445

BenjaminMoe opened this issue Jun 14, 2022 · 4 comments

Comments

@BenjaminMoe
Copy link
Contributor

Allowing for the option of string versus array at the top of each schema introduces a huge block of syntax that is not well understood for functionality that is not really needed. Should we drop strings from type in favor of using only arrays for simplicity?
@nissimsan
Copy link
Collaborator

Related: #524 (comment)

@TallTed
Copy link
Contributor

TallTed commented Aug 30, 2022

maybe retitle "Make all type array of string(s)"

@mkhraisha
Copy link
Collaborator

@nissimsan states I believe we have updated this for steel and e-commerce.

@mkhraisha we will need to do this for Crude oil and gas

@mprorock is this something you would like to do for ag?

@BenjaminMoe BenjaminMoe changed the title Remove optionality of string versus array for type. Make all type array of string(s) Aug 30, 2022
@nissimsan
Copy link
Collaborator

We did this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TallTed @mkhraisha @nissimsan @BenjaminMoe