Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using the "incumbent settings object" #60

Closed
Ms2ger opened this issue Jan 30, 2017 · 5 comments
Closed

Stop using the "incumbent settings object" #60

Ms2ger opened this issue Jan 30, 2017 · 5 comments
Assignees

Comments

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 30, 2017

See whatwg/html#1430 for background.

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 1, 2017

Probably uses current global in Gecko

@domenic
Copy link
Contributor

domenic commented Feb 4, 2017

I've written some (quite fun...) tests which confirm that current seems more correct: web-platform-tests/wpt#4722

@mkruisselbrink can I hand this over to you for test review + spec fixing?

@mkruisselbrink
Copy link
Collaborator

Thanks, had a look at the tests. Also played around a bit more with it. Edge seems to indeed (incorrectly) not serialize the origin in the URL. But it's still possibly to tease out what origin it associates with the blob URL by trying to XHR the resulting URL. And with that it seems that only an XMLHttpRequest instance created using the top (web-platform.test:8000) origin is able to read the blob. So at least edge isn't using the current settings object, but other than that the various settings objects always confuse me. Is that actually the incumbent settings object, or is that entry settings object? Either way it still seems reasonable to change the spec to "current" settings object.

@domenic
Copy link
Contributor

domenic commented Feb 7, 2017

Very interesting. Maybe you could submit extra tests so that we test both the serialization and XHR's ability to access. But yes, I agree we should go ahead with changing the spec and merging the tests.

@domenic
Copy link
Contributor

domenic commented Feb 7, 2017

web-platform.test:8000 is the entry global, BTW; see https://github.com/w3c/web-platform-tests/pull/4722/files#diff-1449b34f69ff3a67cb389f72c59c4496R10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants