Skip to content

Stop using incumbent settings object #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 9, 2017
Merged

Conversation

domenic
Copy link
Contributor

@domenic domenic commented Feb 9, 2017

Fixes #60. Also adds a warning about #63.

I was unable to generate the index.html due to some macro REPOSITORYURL not being present. As such I'm not sure the warning stuff turned out all right. Maybe it would be a good idea to add instructions or a Makefile.

Also adds a warning about #63.
index.bs Outdated
at the time the method that created it was called.

WARNING: there is currently some confusion between the generic definition of the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think "WARNING" is a thing with special meaning in bikeshed. Probably Advisement: or Issue: makes the most sense?

@mkruisselbrink
Copy link
Collaborator

I was unable to generate the index.html due to some macro REPOSITORYURL not being present. As such I'm not sure the warning stuff turned out all right. Maybe it would be a good idea to add instructions or a Makefile.

I'm curious what error you're getting? As far as I know I'm not doing anything special/not special configuration should be needed...

@domenic
Copy link
Contributor Author

domenic commented Feb 9, 2017

I'm curious what error you're getting? As far as I know I'm not doing anything special/not special configuration should be needed...

When I do

curl https://api.csswg.org/bikeshed/ -F file=@index.bs > index.html

I get an index.html that contains

Error running preprocessor, returned code: 1. \033[1;31mFATAL ERROR:\033[0m Found unmatched text macro [REPOSITORYURL]. Correct the macro, or escape it with a leading backslash. \033[7;31m ✘ \033[0m Did not generate, due to fatal errors

@mkruisselbrink
Copy link
Collaborator

Ah, it's probably the fact that there is no "Repository:" metadata listed, instead relying on it being run from within a github checkout. Not sure why bikeshed even lets you do that...

@mkruisselbrink mkruisselbrink merged commit 1a6f054 into gh-pages Feb 9, 2017
@mkruisselbrink
Copy link
Collaborator

Thanks!

@mkruisselbrink mkruisselbrink deleted the no-incumbent branch February 9, 2017 19:41
mkruisselbrink pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants