-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build process non-deterministically produces invalid HTML files #910
Comments
I can confirm this bug on my system. shell output$ grep -Ro '</html' build-* | uniq -c | sort -n | grep -E '^\s*[2-9]'
2 build-1/tests/checkbox-tri-state/reference/2022-9-9_104148/checkbox-mixed.html:</html
2 build-1/tests/combobox-select-only/reference/combobox-select-only.html:</html
2 build-1/tests/datepicker-spin-button/reference/2021-10-15_93728/datepicker-spinbuttons.html:</html
2 build-1/tests/menubar-editor/reference/2020-11-23_175528/menubar-editor.html:</html
2 build-1/tests/minimal-data-grid/reference/2021-3-8_151542/dataGrids.html:</html
2 build-1/tests/modal-dialog/reference/2022-4-7_15544/dialog.html:</html
2 build-2/tests/checkbox/reference/2020-11-23_175030/checkbox-1/checkbox-1.html:</html
2 build-2/tests/combobox-select-only/reference/combobox-select-only.html:</html
2 build-2/tests/horizontal-slider/reference/2022-4-11_11511/slider-color-viewer.html:</html
2 build-2/tests/menu-button-actions-active-descendant/reference/2021-1-14_171136/menu-button-actions-active-descendant.html:</html
2 build-2/tests/modal-dialog/reference/2022-4-7_15544/dialog.html:</html
2 build-3/tests/checkbox-tri-state/reference/2022-9-9_104148/checkbox-mixed.html:</html
2 build-3/tests/checkbox/reference/2020-11-23_175030/checkbox-1/checkbox-1.html:</html
2 build-3/tests/command-button/reference/2022-4-8_124112/button.html:</html
2 build-3/tests/link-span-text/reference/2022-4-6_14258/link.html:</html
2 build-3/tests/radiogroup-aria-activedescendant/reference/2022-4-7_113015/radio-activedescendant.html:</html
2 build-3/tests/radiogroup-roving-tabindex/reference/2021-3-15_144141/radio.html:</html
2 build-4/tests/checkbox/reference/2020-11-23_175030/checkbox-1/checkbox-1.html:</html
2 build-4/tests/radiogroup-roving-tabindex/reference/2021-3-15_144141/radio.html:</html
2 build-4/tests/tabs-manual-activation/reference/2021-2-15_124757/tabs.html:</html
2 build-5/tests/checkbox/reference/2020-11-23_175030/checkbox-1/checkbox-1.html:</html
2 build-5/tests/link-span-text/reference/2022-4-6_14258/link.html:</html
2 build-5/tests/menu-button-actions/reference/2021-1-14_12348/menu-button-actions.html:</html
2 build-5/tests/menu-button-navigation/reference/2022-4-12_14147/menu-button-links.html:</html
2 build-5/tests/minimal-data-grid/reference/2021-3-8_151542/dataGrids.html:</html
2 build-5/tests/radiogroup-roving-tabindex/reference/2021-3-15_144141/radio.html:</html
2 build-5/tests/seek-slider/reference/2021-9-21_14461/slider-seek.html:</html
2 build-5/tests/tabs-manual-activation/reference/2021-2-15_124757/tabs.html:</html |
Oh, I know what this is. Two different file content are being written to the same file path. This is happening to each reference html file that has no setup script. To fix this we need to not add the original reference html file to the build because we create one for the same file path with generated code. |
This was referenced Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On my system (GNU/Linux, Ubuntu 18.04, Node.js 16.17.0), the
npm build
command occasionally outputs invalid HTML files.Steps to reproduce:
Build the HTML files five times, saving the output each time:
Search the five build directories for files with multiple closing HTML tags:
Expected behavior: the search returns zero results
Actual behavior: the search returns one or more results
For my trial, the search returned:
The symptom is more severe than duplicated closing tags; that just happens to be a straightforward way to detect the problem.
Here's a comparison highlighting the invalidity in one of those files
I've scraped all of the test HTML which is currently published on the production deployment of ARIA-AT App, and the good news is that it appears to be valid.
That may mean that the most recent build was lucky (notice how in my trial, the first and fourth build didn't include any duplicated closing HTML tags), or it may mean that this problem is specific to my machine. I'm wondering if anyone else can reproduce the behavior reported here.
The text was updated successfully, but these errors were encountered: