Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Alert Dialog Example #736

Closed
1 of 3 tasks
mcking65 opened this issue Jun 25, 2018 · 4 comments
Closed
1 of 3 tasks

Review Alert Dialog Example #736

mcking65 opened this issue Jun 25, 2018 · 4 comments
Assignees
@jnurthen @shirsha @annabbott
Labels
Example Page Related to a page containing an example implementation of a pattern
Milestone
1.2 Release 1

Comments

@mcking65
Copy link
Contributor

mcking65 commented Jun 25, 2018 •
edited
Loading

With many thanks to @sh0ji, development of the alert dialog example
for issue #101 is complete.

Reviews requested as of June 24, 2018
@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern Needs Review labels Jun 25, 2018
@mcking65 mcking65 added this to the 1.1 APG Release 2 milestone Jun 25, 2018
@annabbott
Copy link

Found a nit: in the sentence "Activating the "yes" button removes the contents of both the "Notes" text area and local storage of the notes ." remove the extra space between the last word in the sentence and the period.

@annabbott
Copy link

Neither Save nor Discard button function in IE11 using kbd or mouse.

@annabbott
Copy link

Tested using Firefox 60.0.2 and Chrome Version 67.0.3396.99 with JAWS 2018.1805.33 and NVDA 2018.1.1 on Win10:: works as designed.

@robfentress
Copy link
Contributor

Could you provide an alternative example where aria-hidden is used to hide content outside of the alert dialog when the dialog is open. At least with your combobox examples you do provide an alternative that is designed to work with older AT because support for the ARIA 1.1 implementation isn't there yet.

@carmacleod carmacleod mentioned this issue Jan 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnurthen jnurthen

@shirsha shirsha

@annabbott annabbott

Labels
Example Page Related to a page containing an example implementation of a pattern
Projects
Alert and Alert Dialog Patterns and Examples Development Project
Status: Complete
Milestone
1.2 Release 1
Development

No branches or pull requests
5 participants
@jnurthen @mcking65 @shirsha @robfentress @annabbott