Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should aria-invalid be a token list? #1045

Closed
joanmarie opened this issue Aug 26, 2019 · 1 comment
Closed

Should aria-invalid be a token list? #1045

joanmarie opened this issue Aug 26, 2019 · 1 comment
Labels

Comments

@joanmarie
Copy link
Contributor

joanmarie commented Aug 26, 2019

The type of aria-invalid is currently a token.

<conversation with colleague>
Me: if you mean if something is a spelling error and a grammar error then I think that's something we've never encountered before
Colleague: Clearly you haven't my wrting.
</conversation with colleague>

Guess he has a point. Hence the question in the summary. Maybe aria-invalid should be a token list.

@aleventhal
Copy link
Contributor

aleventhal commented Aug 26, 2019

-1
I don't think it needs to be a token list, and that will complicate things.
For a single misspelled word, there isn't enough info to mark it as a grammar error, since it's unknown what word was intended anyway.
The case for having both can be done as:

<span aria-invalid="grammar">Here is mine bad <span aria-invalid="spelling">santence<span>.</span>

If the editor in question is really smart it can recognize the bad grammar despite the misspelling, but the bad grammar is going to include the smaller node.

And just in case people want to argue with me, we could do this if we really had to:
<span aria-invalid="grammar"><span aria-invalid="spelling">Yucks</span></span>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants