Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What does (see structure) mean in menuitemradio superclass? #1144

Closed
carmacleod opened this issue Jan 5, 2020 · 6 comments · Fixed by #1145
Closed

What does (see structure) mean in menuitemradio superclass? #1144

carmacleod opened this issue Jan 5, 2020 · 6 comments · Fixed by #1145
Labels
has PR PR exists that will close this issue question

Comments

@carmacleod
Copy link
Contributor

carmacleod commented Jan 5, 2020

The characteristics table for menuitemradio has

  • menuitemcheckbox (see structure)

as one of its superclass roles.

What does the "(see structure)" mean?

  • if it is referring to the abstract role structure, then... why?
  • if it is referring to the structure of a menu or group, then what specifically does that have to do with the menuitemcheckbox superclass?

This seems to be pretty unclear, and it sets a precedent for having additional instructions for superclass role characteristics.

@jnurthen
Copy link
Member

jnurthen commented Jan 6, 2020

my guess is that someone thought this was a little weird so put the hint in to see the structure diagram. IMO we should remove it especially as we aren't really clear what it means.

@carmacleod
Copy link
Contributor Author

Good point - it is definitely a weird little class hierarchy there... I wouldn't expect menuitemradio to be a subclass of menuitemcheckbox (I'd expect both to be subclasses of menuitem). Particularly given that regular radio is not a subclass of regular checkbox - they are both subs of input.

However, as you say, even if "(see structure)" means "(see structure diagram)", it's not helpful, because:

  • the structure diagram would just show the same thing that the superclass listing shows
  • we don't have a structure diagram any more, correct?

I agree with just removing it.

@JAWS-test
Copy link
Contributor

we don't have a structure diagram any more, correct?

The diagram still exists: https://w3c.github.io/aria/#roles_categorization

@carmacleod
Copy link
Contributor Author

Oh, thanks @JAWS-test - I should have looked for it before speaking. :)
It was broken for a while, and I heard talk of removing it because it is wickedly difficult to keep up to date.

Having said that, I've pasted the bit showing the "structure" of the menuitemradio class hierarchy below.
If we keep the diagram, and if we decide that the picture does clarify the relationship between menuitemcheckbox, menuitemradio, menuitem, checkbox, and radio, then we could clarify that bit of text by adding the word "diagram" and including a link, something like:

(see structure diagram)

Here's the portion of the diagram that includes those classes:
image

@scottaohara
Copy link
Member

even with the diagram, seems removing the text is a good call. Otherwise, why is it just used here?

@JAWS-test
Copy link
Contributor

and I heard talk of removing it because it is wickedly difficult to keep up to date

I find the diagram itself useful and would like to see it updated further. If that's too much work, of course it can be done without. I cannot estimate how intensively it is used.

The reference to the diagram at menuitemradio should be removed.

@scottaohara scottaohara added the has PR PR exists that will close this issue label Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has PR PR exists that will close this issue question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants