Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize data-at-shortcutkeys ?? #1257

Closed
jnurthen opened this issue May 1, 2020 · 9 comments
Closed

standardize data-at-shortcutkeys ?? #1257

jnurthen opened this issue May 1, 2020 · 9 comments
Milestone

Comments

@jnurthen
Copy link
Member

jnurthen commented May 1, 2020

I recently heard about this
https://support.freedomscientific.com/Training/Surfs-Up/BypassNavigationQuickKeys.htm

Is this the same thing covered by aria-keyshortcuts (I think not but haven't looked into it in detail).
As this was apparently done for facebook maybe @mcking65 can shed some more light on it.

@carmacleod
Copy link
Contributor

They sure do seem similar, although the JAWS data-at-shortcutkeys feature does not seem to support modifier keys (i.e. it seems to only support single-character Navigation Quick Keys).
(Heh, I'll bet the corresponding SHIFT+key still does reverse navigation - just guessing, though).

Not sure if JAWS supports aria-keyshortcuts at all? This JAWS ARIA Support table (last updated a year ago) has ? under aria-keyshortcuts, and this Accessibility Support site says "We do not currently have any data on this feature.".

TBH, I don't know if any AT supports aria-keyshortcuts?

@jnurthen jnurthen added this to the ARIA 1.4 milestone May 7, 2020
@JAWS-test
Copy link
Contributor

JAWS-test commented May 8, 2020

Not sure if JAWS supports aria-keyshortcuts at all?

JAWS supports aria-keyshortcuts very well. Provided the property is correctly passed from the browser to the Accessibility API, JAWS outputs the accesskeys during tab navigation, when reading with the virtual cursor, and sometimes even in the element overview. The output works for interactive elements as well as for non-interactive elements (such as span).
Unfortunately, aria-keyshortcuts is not supported by Firefox and IE 11. But this is a browser bug. JAWS only outputs access keys correctly with Chrome and Edge (Chromium). See FreedomScientific/standards-support#246

I don't know if any AT supports aria-keyshortcuts?

Also applies to NVDA. aria-keyshortcurs works with Edge and Chrome, not with IE 11 and Firefox

They sure do seem similar

In my opinion, these are different things

  • aria-keyshortcuts only informs about access keys (and is therefore a good addition to the HTML attribute accesskey and can be used if the HTML attribute is not used)
  • data-at-shortcutkeys, on the other hand, ensures that JAWS does not use the access keys for its own operation, but passes them directly to the browser. This is similar to the application mode

However, data-at-shortcutkeys does not work in my test environment (JAWS 2019 and JAWS 2020 with IE, Firefox, Edge, Chrome).

@JAWS-test
Copy link
Contributor

I think the data-at-shortcutkeys deal between Freedom Scientific and Facebook is very problematic because

  • the technique will not work with other screen readers
  • a new attribute has been introduced that is not in line with the ARIA standard
  • Many JAWS users will not know the feature and will not understand why their JAWS keys no longer work as usual
  • There is no need for the attribute because there are enough well-known methods in JAWS for passing keys to the browser
  • it is very questionable whether the Facebook implementation in connection with data-at-shortcutkeys takes into account the requirements of WCAG 2.1.4. Since I don't have a Facebook account, I can't check this myself

@carmacleod
Copy link
Contributor

Thank-you @JAWS-test for the useful info. Good to know that JAWS works well with aria-keyshortcuts (in supporting browsers), and thanks for pointing out how these are 2 very different things.

I think the data-at-shortcutkeys deal between Freedom Scientific and Facebook is very problematic

You are not the only one who thinks this is problematic. @mcking65 agrees with you, as do others in the ARIA Working Group.

@carmacleod
Copy link
Contributor

@JAWS-test You said:

However, data-at-shortcutkeys does not work in my test environment (JAWS 2019 and JAWS 2020 with IE, Firefox, Edge, Chrome).

Do you think the feature may have been removed? i.e. did your test case work with previous versions of JAWS?

@JAWS-test
Copy link
Contributor

Do you think the feature may have been removed?

I don't think so, because the JAWS setting to enable this feature is still available: "Allow Web Application Reserved Keystrokes" (see https://support.freedomscientific.com/Training/Surfs-Up/BypassNavigationQuickKeys.htm)

@carmacleod
Copy link
Contributor

the JAWS setting to enable this feature is still available

Good point. If the feature was removed, the setting would also be removed.

@jnurthen jnurthen removed the deep-dive label Jul 9, 2020
@carmacleod
Copy link
Contributor

@jamesn Can this be closed? It does not seem generally useful.

@mcking65
Copy link
Contributor

Just for the record, I support closing this as I do not support standardizing the data attribute for shortcut keys.

It was a tactical solution to a practical problem negotiated between Facebook and Freedom Scientific prior to when I became a Facebook employee.

I recently started working with Vispero to phase out use of this feature on Facebook.

As far as I know, the only other site using it is Twitter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants