Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does aria-label trigger presentation role conflict? #1824

Closed
WilcoFiers opened this issue Oct 6, 2022 · 2 comments · Fixed by #1852
Closed

Does aria-label trigger presentation role conflict? #1824

WilcoFiers opened this issue Oct 6, 2022 · 2 comments · Fixed by #1852
Assignees
Labels
1.3-Blocking Blocking issues for 1.3 WRWD needs-automated-test Needs an additional automated test via WPT computedLabel(), computedRole(), or other methods.
Milestone

Comments

@WilcoFiers
Copy link
Contributor

In ARIA 1.2 the concept of prohibited properties and states was introduced. This included prohibiting aria-label and aria-labelledby on presentation and none. Reading the description of global attributes then seems to suggest (but not explicitly state) that prohibited props are not global.

6.5 Global States and Properties

... The following global states and properties are supported by all roles and by all base markup elements unless otherwise prohibited...

  • aria-label (Except where prohibited)

If aria-label is no longer considered a global property for presentation, that means using it wouldn't cause presentational role conflict to occur, and so some browsers have started ignoring aria-label when used on presentational elements (implicit and explicit):

<img src="img1.png" alt="" aria-label="Hello world" />
<img src="img2.png" role="none" aria-label="Hello world" />
Browser img1 img2
Firefox Included Included
Chrome Included Skipped
Safari Skipped Included

It's not clear whether or not this was the intended behavior for prohibited properties. In either case it would be good for the presentational role conflict resolution to clarify what should happen with prohibited attributes.

This issue came up in migrating ACT rules to WAI-ARIA 1.2, and is one of the outstanding questions we have for updating our Element marked as decorative is not exposed rule.

@scottaohara
Copy link
Member

can see why you'd come away with that interpretation, this needs to be more clear. But the attributes are still global and 'prohibited' is presently an author requirement, not one for UA.

This issue should be considered / will likely be covered by what is needed to resolve #1288 / #1474 (and many more issues related to the topic of the presentational conflict resolution).

@jnurthen jnurthen added this to the ARIA 1.2 milestone Oct 6, 2022
@jnurthen jnurthen self-assigned this Oct 6, 2022
@jnurthen jnurthen modified the milestones: ARIA 1.2, ARIA 1.3 Oct 6, 2022
@jnurthen jnurthen added the 1.3-Blocking Blocking issues for 1.3 WRWD label Oct 6, 2022
@cookiecrook cookiecrook added the needs-automated-test Needs an additional automated test via WPT computedLabel(), computedRole(), or other methods. label Nov 3, 2022
@jnurthen
Copy link
Member

Tests created by #1938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.3-Blocking Blocking issues for 1.3 WRWD needs-automated-test Needs an additional automated test via WPT computedLabel(), computedRole(), or other methods.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants