Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate tabpanel with its tab - "either by ... or by ..." #2032

Closed
giacomo-petri opened this issue Sep 8, 2023 · 0 comments · Fixed by #2053
Closed

Associate tabpanel with its tab - "either by ... or by ..." #2032

giacomo-petri opened this issue Sep 8, 2023 · 0 comments · Fixed by #2053
Assignees
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo good first issue

Comments

@giacomo-petri
Copy link
Contributor

Suggested change
I'm not a native English speaker, but while reading the tabpanel specifications:

Authors SHOULD associate a tabpanel element with its tab, either by using the aria-controls attribute on the tab to reference the tab panel, or by using the aria-labelledby attribute on the tab panel to reference the tab.

It appears to me as if it's saying "do this OR do this," not both. Since both options are allowed and also recommended by the ARIA practices (https://www.w3.org/WAI/ARIA/apg/patterns/tabs/examples/tabs-automatic/), should we perhaps rephrase the sentence as follows:

Authors SHOULD associate a tabpanel element with its tab, by using the aria-controls attribute on the tab to reference the tab panel, and/or by using the aria-labelledby attribute on the tab panel to reference the tab.

I've noticed that "and/or" has already been used elsewhere in the document.

Link: https://w3c.github.io/aria/#tabpanel

@giacomo-petri giacomo-petri added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Sep 8, 2023
@giacomo-petri giacomo-petri self-assigned this Sep 29, 2023
@pkra pkra closed this as completed in #2053 Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo good first issue
Projects
None yet
2 participants