Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARIA roles in ToC #534

Closed
marcoscaceres opened this issue Mar 13, 2017 · 5 comments
Closed

ARIA roles in ToC #534

marcoscaceres opened this issue Mar 13, 2017 · 5 comments
Assignees
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo needinfo

Comments

@marcoscaceres
Copy link
Member

Can we please make the aria role show up in the ToC? It's super frustrating for people trying to find them that they are not listed and easily accessible.

@jnurthen
Copy link
Member

I'm happy to do this if we think it is a good idea. @joanmarie @michael-n-cooper what do you say?

@jnurthen jnurthen self-assigned this Jan 11, 2019
@joanmarie
Copy link
Contributor

joanmarie commented Jan 14, 2019

Hmmmm....

On the one hand "super frustrating" sounds bad. :( On the other hand, for people who aren't using the sidebar popout, the current table of contents is already pretty huge, and adding every single role would make it even more huge. As someone who uses rotated monitors (table of contents is not popped out, but instead appears at the top of the page), I don't think I'd like to see the table of contents double in size.

Thinking out loud....

We currently already have the following items in the Table of Contents:

  • Categorization of Roles (which has links to the items I list below)
  • Abstract Roles
  • Widget Roles
  • Document Structure
  • Landmark Roles
  • Live Region Roles
  • Window Roles

And, at least in the TR version (the github.io version seems a tad broken in this regard), each of those sections has links to each role. For instance, see Widget Roles.

So, I'd like to find a way to make the roles easier to find without necessarily growing the table of contents significantly. @marcoscaceres do you have any ideas on a compromise solution, or do you feel it is essential that we add all roles to the TOC?

@jnurthen
Copy link
Member

Based on @joanmarie comments - @marcoscaceres do you have any ideas to resolve this?

@marcoscaceres
Copy link
Member Author

So, did a little poking around... the problem is that "rdef" are rewritten after the TOC is generated.

Is @halindrome still working on this spec? If yes, maybe he can get it to expand those before the conformance runs and when ReSpec starts up?

@pkra pkra added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Jun 27, 2023
@pkra
Copy link
Member

pkra commented Jun 27, 2023

Re-reading this, I'm not sure there ever was agreement on what to do. Since this has been stale for years, I'll close it. @marcoscaceres feel free to re-open.

FWIW I agree with Joanie - adding every a link for every role to the TOC seems very noisy to me, especially since I feel we should then also add every state and property.

@pkra pkra closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2023
@pkra pkra added the needinfo label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo needinfo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants