Issue737 menuitem and groups #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanmarie
reviewed
Jul 10, 2018
index.html
Outdated
| @@ -4201,7 +4205,7 @@ <h4>Plain HTML or Polyfill DOM Result of the MathML Quadratic Formula</h4> | |||
| <div class="role-description"> | |||
| <p>An option in a set of choices contained by a <rref>menu</rref> or <rref>menubar</rref>.</p> | |||
| <p>Authors MAY disable a menu item with the <sref>aria-disabled</sref> attribute. If the menu item has its <pref>aria-haspopup</pref> attribute set to <code>true</code>, it indicates that the menu item may be used to launch a sub-level menu, and authors SHOULD display a new sub-level menu when the menu item is activated.</p> | |||
| <p>Authors MUST ensure that menu items are <a>owned</a> by an element with role <rref>menu</rref> or <rref>menubar</rref> in order to identify that they are related <a>widgets</a>. Authors MAY separate menu items into sets by use of a <rref>separator</rref> or an element with an equivalent role from the native markup language.</p> | |||
| <p>Authors MUST ensure that menu items are <a>owned</a> by an element with role <rref>group</rref>, <rref>menu</rref> or <rref>menubar</rref> in order to identify that they are related <a>widgets</a>. Authors MAY separate menu items into sets by use of a <rref>separator</rref> or an element with an equivalent role from the native markup language.</p> | |||
There was a problem hiding this comment.
This to me suggests that a menuitem inside a group is valid even if that group does not descend from a menu. Do we want to clarify that menuitem instances must be contained within a menu?
jnurthen
added a commit
that referenced
this pull request
Oct 23, 2019
* Issue #737 * resolve inconsistencies around menuitems being allowed in groups * allow menuitemcheckbox to be in a group.
straker
pushed a commit
to dequelabs/axe-core
that referenced
this pull request
Feb 9, 2021
…1.2 (#2737) * Allow 'menuitem' and 'menuitemcheckbox' to be in a 'group', per ARIA 1.2 Fixes: #2736 Spec issue: w3c/aria#737 Spec PR: w3c/aria#784 * tests: Add happy and sad path tests for role=group * feat: Make 'getMissingContext' check 'group'’s parent’s role * fix: Test 'role=group' is disallowed * fix: Only permit role=group when it’s an allowed context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff