New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE: Added Gen2 Multi Domain Vehicle Taxonomy #315
Conversation
* Added and described the term * Restructured the chapters * Added skeleton for further description Fixes: w3c#306
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion, change to "schema file" instead of Basic Rules.
Make clear that Data Definition is an example for the Domain Vehicle Signals.
<p>A leaf the same as <a>sensor</a> which additionaly can be changed.</p> | ||
|
||
<section id="datadefinition"> | ||
<h3>Data Definition</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An example for a Domain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean I should change the title? I would hope that we add domains here before we finish the spec, that's why I defined it like this. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean I should change the title? I would hope that we add domains here before we finish the spec, that's why I defined it like this. What do you think?
Adding multiple domains here sounds good, but it felt to me to be build for only one. If you could at something that makes that more clear that would be very much appreciated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding multiple domains here sounds good, but it felt to me to be build for only one. If you could at something that makes that more clear that would be very much appreciated.
Let’s have a goal to get the multimedia domain there. I checked your mail, but I think it's hard to discuss via mail. Would you agree that I add your vspec file to my clone of this repo? Then we can take it from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PatrickCQ: In the last commit I added some more description for the data definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The minimum value for a signed 64-bit integer is -(2^63)
, you have the positive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In figure 1 the name of the root node should be Vehicle.
The datatypes Float and Double should maybe have references to their exact definitions, as these are not uniquely defined by their names only?
Good point @UlfBj. Changed it.
Where do you mean exactly? |
I had forgot the details of the float/double format so I looked it up, and it said most computers followed this standard: https://en.wikipedia.org/wiki/IEEE_754 |
In order to make it exact how about float32 float64 and float128 to express
float, double and decimal respectively?
On Thu, 7 Nov 2019 at 19:47 Ulf Björkengren ***@***.***> wrote:
The datatypes Float and Double should maybe have references to their exact
definitions, as these are not uniquely defined by their names only?
Where do you mean exactly?
I had forgot the details of the float/double format so I looked it up, and
it said most computers followed this standard:
https://en.wikipedia.org/wiki/IEEE_754
So maybe it would be good to refer to it? If so, where these are mentioned
in the chapter.
It is fine with me to skip it, if "most computers" means almost all
computers.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#315?email_source=notifications&email_token=AA4IL3NY3G4EVSAGCXJPAWTQSRPDXA5CNFSM4JKGIFOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDNNHCQ#issuecomment-551211914>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4IL3IN2OLJAGXCPMJZEB3QSRPDXANCNFSM4JKGIFOA>
.
--
- Patrick (Mobile)
|
the data types are not really part of the changes @danielwilms proposed. He just copied that part around to a better location in the document. In my opinion we should discuss data types in a separate issue to not overload this proposed change. |
Weaken the requirement from SHALL to SHOULD following RFC2119: "SHOULD This word, or the adjective "RECOMMENDED", mean that there may exist valid reasons in particular circumstances to ignore a particular item, but the full implications must be understood and carefully weighed before choosing a different course."
After discussion with Daniel that the content of this PR has since its creation become obsolete in view of other accepted PRs, it is now closed. |
Readable Version
Fixes: #306