-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updateWith will silently ignore data in hard-to-debug ways #350
Comments
If this returning a promise idea were desired, it'd be a slight breaking change, as all the synchronous error throwing would become rejected promise-returning. |
@domenic, given that it returns void right now, would it be that harmful to start returning a promise? |
I don't think so, but who knows, maybe people are try-catching the errors it produces. |
domenic
added a commit
to domenic/browser-payment-api
that referenced
this issue
Feb 9, 2017
This closes w3c#350. It is a slightly backward-incompatible change in that consumers which were previously try-catching errors will no longer see them. But consumers that were always passing valid data, or passing invalid data and not try-catching the errors, will see no changes.
domenic
added a commit
that referenced
this issue
Mar 8, 2017
Previously, it would ignore any bad data. Now it validates the data ahead of time before performing any updates. Closes #350.
zkoch
pushed a commit
that referenced
this issue
Mar 22, 2017
) * Make updateWith() reject the show() promise on validation failures Previously, it would ignore any bad data. Now it validates the data ahead of time before performing any updates. Closes #350. * Also disallow negative modifiers in updateWith * Update the model for the "error" member to match discussion * Move the negative check to the correct spot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are various cases in which updateWith will ignore the data its argument promise is resolved with. For example, it will ignore various negative amounts, onvalid decimal monetary values, etc.
When this happens, there is no indication to the caller of updateWith that anything went wrong. Should there be (e.g. via a Promise that updateWith returns)? I assume UAs are free to report things to the console here, of course, but that only helps if the page author is reproducing the problem themselves...
The text was updated successfully, but these errors were encountered: