Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the images #332

Closed
xfq opened this issue Sep 1, 2020 · 3 comments
Closed

Optimize the images #332

xfq opened this issue Sep 1, 2020 · 3 comments

Comments

@xfq
Copy link
Member

xfq commented Sep 1, 2020

With more and more images added to clreq, the page load time is getting longer and longer, so we should optimize the images, similar to w3c/jlreq#218
@r12a
Copy link
Contributor

r12a commented Sep 1, 2020

I ran the jlreq images through ImageOptim. Did we do anything else with them?

@xfq
Copy link
Member Author

xfq commented Sep 2, 2020

We did not, but Shimono-san and Kida-san proposed to add loading=lazy to the img elements. I don't have strong opinion on this, but I think the images should be optimized.

@r12a
Copy link
Contributor

r12a commented Sep 2, 2020

I just uploaded optimised images for
images/zh Saved 539 KB out of 1.1 MB. 48.6% overall (up to 77.9% per file)
images/en (one file) Reduced by 76.7%.

Most of the images are SVG (those weren't optimised).

@r12a r12a closed this as completed Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xfq @r12a