Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename directory css-animationworklet to css-animation-worklet #959

Closed
majido opened this issue Sep 26, 2019 · 3 comments
Closed

Rename directory css-animationworklet to css-animation-worklet #959

majido opened this issue Sep 26, 2019 · 3 comments

Comments

@majido
Copy link
Contributor

majido commented Sep 26, 2019

Animation Worklet is two words and the shortname for its spec is css-animation-worklet. However its directory in houdini is css-animationworklet which does not match this.

We should rename this directory to css-animation-worklet.
The only concern I have is how it will affect the existing URLs? In particular

Ideally it will be nice if we could redirect these to the new URLs with additional -. It seems that drafts.css-houdini.org has some built-in functionality for redirection. @tabatkins do you know if this is true and how I can leverage this?

Notes:

@tabatkins
Copy link
Member

We have some magic for level-based redirecting, but I don't think we do for just straight renaming. @plinss?

@plinss
Copy link
Member

plinss commented Sep 26, 2019

The draft server also has support for redirecting based on an old name. For some cases it's better to simply add a redirect to the web server.

There's also the issue of tests with rel="help" links to the draft if we change the canonical URL for the draft.

@majido
Copy link
Contributor Author

majido commented Oct 8, 2019

I can manually update the tests rel="help" links.

So given that we have redirect ability I will go ahead and make the directory rename and then @plinss can add a redirect from the old names:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants