Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] inverting a type should preserve the percent hint #10018

Closed
dbaron opened this issue Feb 29, 2024 · 1 comment
Closed

[css-typed-om] inverting a type should preserve the percent hint #10018

dbaron opened this issue Feb 29, 2024 · 1 comment

Comments

@dbaron
Copy link
Member

dbaron commented Feb 29, 2024

So after looking at some of the spec rules for #10017, I'm concerned that dividing (in calc()) by values with percentages produces inconsistent results. The rules for invert invert (and preserve) percent types but erase percent hints. This means when a percentage in the divisor leads to it having a "percent" type it is preserved, but when it leads to a percent hint, it is removed. For example this means that calc(30px / 20%) has a type that involves percentages whereas calc(30px / (20% + 10px)) does not. This seems wrong, and it seems like inverting a type should preserve the percent hint rather than erasing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants