Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-view-transitions-1] Should handle transition frame avoid calling "update pseudo-element styles" when all animations are paused? #10735

Closed
nt1m opened this issue Aug 13, 2024 · 4 comments

Comments

@nt1m
Copy link
Member

nt1m commented Aug 13, 2024

https://drafts.csswg.org/css-view-transitions/#handle-transition-frame-algorithm

Right now it calls "update pseudo-element styles" when everything is paused, I'm debugging a VT issue, and it's a lot of noise in the logging, but it's also a waste of cycles.

cc @khushalsagar @noamr @vmpstr

@nt1m
Copy link
Member Author

nt1m commented Aug 13, 2024

(Since we do have to go through all keyframes anyway to see if we can stop the VT, I suspect we can get whether everything is paused)

@nt1m
Copy link
Member Author

nt1m commented Aug 13, 2024

(Since we do have to go through all keyframes anyway to see if we can stop the VT, I suspect we can get whether everything is paused)

I guess it's not quite the case, since we early return if we see a paused animation when checking for running ones

@noamr
Copy link
Collaborator

noamr commented Aug 13, 2024

I don't think we can do this, because the new element's geometry can change programmatically outside of animations.

@nt1m
Copy link
Member Author

nt1m commented Aug 13, 2024

Ah right, the new element geometry is translated to the pseudo-element. I was too focused on my issue I forgot about that

@nt1m nt1m closed this as completed Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants