Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cssom] Consider removing setPropertyValue / setPropertyPriority. #2680

Closed
emilio opened this issue May 15, 2018 · 2 comments
Closed

[cssom] Consider removing setPropertyValue / setPropertyPriority. #2680

emilio opened this issue May 15, 2018 · 2 comments
Labels

Comments

@emilio
Copy link
Collaborator

emilio commented May 15, 2018

They haven't been implemented anywhere even though they're in the spec since forever, and I'm trying to get every UA to do the spec'd thing in setProperty and finally be interoperable here.

They'd also do the wrong thing with logical properties, etc.

So it would be nice if, lacking a good use-case for this and implementation interest, this was removed from the spec.

This is conceptually something that could be done, however we'd end up with a bit of pain trying to define how it should interact with mutation observers and such, which is something that no UA has implemented interoperably in setProperty until lately.

@zcorpan @dbaron wdyt?

@emilio emilio added the cssom-1 label May 15, 2018
@zcorpan
Copy link
Member

zcorpan commented May 15, 2018

OK with me. They were added to give web developers an opt in to saner behavior than setProperty, by request from @dbaron, iirc, but if they haven't been implemented then they should be removed.

@emilio
Copy link
Collaborator Author

emilio commented May 17, 2018

I think you can opt-in into @dbaron's proposed behavior now with setProperty('foo', 'value', getPropertyPriority('foo')) after #1898, and they would have the same problem as #1898 as written, so I think we should remove.

@emilio emilio closed this as completed in 02daf7f May 17, 2018
emilio added a commit to emilio/web-platform-tests that referenced this issue May 25, 2018
Adds tests for getPropertyCSSValue stuff, and also for
w3c/csswg-drafts#2680, while I was here.
gsnedders pushed a commit to web-platform-tests/wpt that referenced this issue May 25, 2018
Adds tests for getPropertyCSSValue stuff, and also for
w3c/csswg-drafts#2680, while I was here.
bors-servo pushed a commit to servo/servo that referenced this issue Jun 2, 2018
dom: Remove CSSStyleDeclaration.setPropertyValue/setPropertyPriority.

They were removed from the spec, see w3c/csswg-drafts#2680, and setPropertyValue was wrongly implemented anyway.
bors-servo pushed a commit to servo/servo that referenced this issue Jun 2, 2018
dom: Remove CSSStyleDeclaration.setPropertyValue/setPropertyPriority.

They were removed from the spec, see w3c/csswg-drafts#2680, and setPropertyValue was wrongly implemented anyway.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20901)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this issue Jun 2, 2018
dom: Remove CSSStyleDeclaration.setPropertyValue/setPropertyPriority.

They were removed from the spec, see w3c/csswg-drafts#2680, and setPropertyValue was wrongly implemented anyway.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20901)
<!-- Reviewable:end -->
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jun 10, 2018
…, a=testonly

Automatic update from web-platform-tests[cssom] Add a few more historical tests. (#11163)

Adds tests for getPropertyCSSValue stuff, and also for
w3c/csswg-drafts#2680, while I was here.
--

wpt-commits: 8111e49db7ed5ced2d44e974fcedaba6cd86e4a7
wpt-pr: 11163
xeonchen pushed a commit to xeonchen/gecko-cinnabar that referenced this issue Jun 12, 2018
…, a=testonly

Automatic update from web-platform-tests[cssom] Add a few more historical tests. (#11163)

Adds tests for getPropertyCSSValue stuff, and also for
w3c/csswg-drafts#2680, while I was here.
--

wpt-commits: 8111e49db7ed5ced2d44e974fcedaba6cd86e4a7
wpt-pr: 11163
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
…, a=testonly

Automatic update from web-platform-tests[cssom] Add a few more historical tests. (#11163)

Adds tests for getPropertyCSSValue stuff, and also for
w3c/csswg-drafts#2680, while I was here.
--

wpt-commits: 8111e49db7ed5ced2d44e974fcedaba6cd86e4a7
wpt-pr: 11163

UltraBlame original commit: 24e14dfd9d8d5a7092cb1266e76cdd872ae51d70
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
…, a=testonly

Automatic update from web-platform-tests[cssom] Add a few more historical tests. (#11163)

Adds tests for getPropertyCSSValue stuff, and also for
w3c/csswg-drafts#2680, while I was here.
--

wpt-commits: 8111e49db7ed5ced2d44e974fcedaba6cd86e4a7
wpt-pr: 11163

UltraBlame original commit: 24e14dfd9d8d5a7092cb1266e76cdd872ae51d70
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
…, a=testonly

Automatic update from web-platform-tests[cssom] Add a few more historical tests. (#11163)

Adds tests for getPropertyCSSValue stuff, and also for
w3c/csswg-drafts#2680, while I was here.
--

wpt-commits: 8111e49db7ed5ced2d44e974fcedaba6cd86e4a7
wpt-pr: 11163

UltraBlame original commit: 24e14dfd9d8d5a7092cb1266e76cdd872ae51d70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants