Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

letter-spacing should take a percentage that scales each individual glyph's advance? #5965

Closed
litherum opened this issue Feb 9, 2021 · 4 comments

Comments

@litherum
Copy link
Contributor

litherum commented Feb 9, 2021

In #5533, we resolved to add advance-override which takes a percentage, which scales up each individual glyph's advance.

Maybe letter-spacing should be able to achieve a similar effect?

@litherum
Copy link
Contributor Author

litherum commented Feb 9, 2021

Another way of solving this inconsistency would be to change advance-override instead, to accept a grammar that matches letter-spacing.

@fantasai
Copy link
Collaborator

fantasai commented Feb 9, 2021

Um. I can't imagine anyone wanting tracking that's proportional to the glyph advance width in a proportional font, it would look really messed up for 'm' to have more spacing than 'i', right?

@litherum
Copy link
Contributor Author

litherum commented Feb 9, 2021

Why should advance-override be different from letter-spacing then?

@fantasai
Copy link
Collaborator

fantasai commented Mar 3, 2021

@litherum Because it's trying to fake being a different font, not trying to add tracking. Tracking should be added via letter-spacing.

@litherum litherum closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants