[mediaqueries-4] Lift parens to <media-in-parens> #6806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For container queries (css-contain-3), it would be convenient to be able to reference paren-less <media-feature>, since that grammar wants to wrap the value in a function rather than plain parentheses.
|
Yeah, I like that organization a little better too, keeping all the parens up in the same production. |
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Nov 25, 2021
In order to make it easier to define the grammar of container queries, there was a change in the spec regarding where parens enclosing a <media-feature> are handled. Previously, the parens were part of <media-feature> itself, but as of [1] they were lifted to the <media-in-parens> production. This CL represents the corresponding change in our parser, as a preparation for implementing the container queries syntax. MediaQueryFeatureExpNode now represents the "bare" <media-feature>, without any parens in its serialization. The parens are added explicitly as a MediaQueryNestedExpNode wrapped around the MediaQueryFeatureExpNode. [1] w3c/csswg-drafts#6806 Bug: 1214810 Change-Id: I69c0082fac02d18623beed06228be57a91e7c282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3301699 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#945339}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
In order to make it easier to define the grammar of container queries, there was a change in the spec regarding where parens enclosing a <media-feature> are handled. Previously, the parens were part of <media-feature> itself, but as of [1] they were lifted to the <media-in-parens> production. This CL represents the corresponding change in our parser, as a preparation for implementing the container queries syntax. MediaQueryFeatureExpNode now represents the "bare" <media-feature>, without any parens in its serialization. The parens are added explicitly as a MediaQueryNestedExpNode wrapped around the MediaQueryFeatureExpNode. [1] w3c/csswg-drafts#6806 Bug: 1214810 Change-Id: I69c0082fac02d18623beed06228be57a91e7c282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3301699 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#945339} NOKEYCHECK=True GitOrigin-RevId: 80c8bb264c8128885bf486e818129c4d2ecd5f47
cdoublev
added a commit
to cdoublev/csswg-drafts
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For container queries (css-contain-3), it would be convenient to
be able to reference paren-less
<media-feature>, since that grammarwants to wrap the value in a function rather than plain parentheses.
As far as I can tell,
<media-feature>is only used by<media-in-parens>,so this should be safe.