-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-fonts] Consider always serializing the angle for font-style: oblique
#8291
Comments
I think it's a great idea! I don't see a downside (other than it kind of violates the shortest serialization principle), but being explicit about what oblique means seems like a good idea. Especially if it changes in the future! |
It would mean that the serialized form would be incompatible with older UAs that only support the |
@jfkthame The problem is that "default angle" means 20deg or 14deg depending on the browser version, and that is problematic for backwards compatibility. If a website developed for an older UA reads
|
I don't think old sites or browsers tended to assume anything specific about the angle of slant. (In gecko, at least, I don't recall ever having a 20° slant, although it may at one time have been somewhat platform-dependent rather than being explicitly managed.) What I'm uncomfortable about here is that we'd be changing the serialization of [edit: Checking the history of CSS Fonts 4, it seems |
Right, although I recall seeing some 20deg assumptions in WPT fairly recently, like in the last year. I understand the concern about backwards compat with in-the-wild code that was correct with CSS2 or CSS Fonts 3, but also understand the concern about 14deg vs. 20deg which affects more modern code. Not seeing an obvious path forward here. |
(Up until this week, WebKit used 20deg instead of 14deg.) |
Right now, the angle should only be serialized "if specified" according to the spec.
http://w3c.github.io/csswg-drafts/css-fonts-4/#font-style-prop
Given the default angle has changed from 20deg to 14deg, I think it is better to always serialize the angle for backwards compatibility, since a website may expect oblique to mean either.
The text was updated successfully, but these errors were encountered: