[css-text-4] Clarify fonts without enough blank may not be trimmed #9225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kojiishi
force-pushed
the
text-spacing-trim-give-up
branch
from
376f667
to
a7c08a8
Compare
|
Reworded a bit, hope this is better English ;-) |
frivoal
reviewed
Oct 4, 2023
css-text-4/Overview.bs
Outdated
| @@ -8337,6 +8337,13 @@ Fullwidth Punctuation Collapsing</h4> | |||
| the font has proportional ideographs | |||
| and the fullwidth advance width cannot be reliably determined by measuring glyphs. | |||
|
|
|||
| Some fonts have fullwidth punctuation characters | |||
| whose blank are too small to trim (kern.) | |||
| UA may not trim (kern) | |||
There was a problem hiding this comment.
Suggested change
| UA may not trim (kern) | |
| UA may choose not to trim (kern) |
Otherwise "may not" is ambiguous, and could be seen as meaning the same as "must not"
There was a problem hiding this comment.
Done, thank you for the review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address the risk mentioned at #8292, this change allows UA to not to trim when there's not enough blank.