Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid-1][masonry] Replaced content items should stretch by default. #9327

Open
fantasai opened this issue Sep 7, 2023 · 3 comments
Open
Labels

Comments

@fantasai
Copy link
Collaborator

fantasai commented Sep 7, 2023

In #9041 (comment) @bfgeek suggests that in Masonry layout, replaced elements should stretch by default (like non-replaced elements) rather than remaining start-aligned.

(Fwiw, I'm not convinced that there's a reason for Masonry and Grid to diverge here.)

@tabatkins
Copy link
Member

The reason to diverge is that I don't think I've ever seen a masonry layout with images in the wild that didn't stretch the images to fill the track. It would look pretty weird/bad for the track to have a "ragged edge" from start-aligned images by default.

@fantasai
Copy link
Collaborator Author

fantasai commented Sep 9, 2023

@tabatkins Images don't stretch by default anywhere else in CSS though, so it would be pretty inconsistent.

(Also, most of those you've seen in the wild were probably images inside non-replaced elements that stretched.)

@bfgeek
Copy link

bfgeek commented Sep 9, 2023

They stretch in flexbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants