Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial pass #39

Merged
merged 7 commits into from
Sep 28, 2017
Merged

Editorial pass #39

merged 7 commits into from
Sep 28, 2017

Conversation

anssiko
Copy link
Member

@anssiko anssiko commented Sep 27, 2017

  • Update spec names
  • Editorial nits, remove trailing "." from list items
  • Update Charter history

PTAL @dontcallmedom

- Update spec names
- Editorial nits, remove trailing "." from list items
- Update Charter history
@anssiko
Copy link
Member Author

anssiko commented Sep 28, 2017

Proposed one more change 0ca6676, while not strictly editorial, rolled it into this branch for convenience.

Copy link
Member

@dontcallmedom dontcallmedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggesting an additional fix, but otherwise lgtm

@@ -48,7 +48,7 @@

<h1 id="title">[DRAFT] Device and Sensors Working Group Charter</h1>

<p><em>This is a draft revised Device APIs Working Group (renamed Device and Sensors Working Group) charter for discussion. It has no standing. See also the <a href="https://www.w3.org/2016/03/device-sensors-wg-charter.html">charter under which the Device APIs Working Group</a> currently operates.</em></p>
<p><em>This is a draft revised Device APIs Working Group (renamed Device and Sensors Working Group) charter for discussion. It has no standing. See also the <a href="https://www.w3.org/2016/03/device-sensors-wg-charter.html">charter under which the Device and Sensors Working Group</a> currently operates.</em></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe flip the first: Device APIs Working Group (renamed Device and Sensors Working Group) -> Device and Sensors Working Group (formerly known as Device APIs Working Group); or drop the mention of Device APIs completely?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed fix 69ec9e9

@anssiko
Copy link
Member Author

anssiko commented Sep 28, 2017

@dontcallmedom, I pushed b265f79 to this branch since your previous comment, PTAL.

@dontcallmedom
Copy link
Member

still LGTM :)

@anssiko
Copy link
Member Author

anssiko commented Sep 28, 2017

Feel free to merge. If I find other editorial changes I can open another PR.

(btw. what is the DL to get editorial changes in?)

@dontcallmedom dontcallmedom merged commit a3a9cc7 into gh-pages Sep 28, 2017
@dontcallmedom
Copy link
Member

it would be good to get all changes in before next Tuesday, so that we can bring this to W3C management review next Wednesday

@anssiko anssiko deleted the editorial branch October 4, 2017 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants