-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial pass #39
Editorial pass #39
Conversation
- Update spec names - Editorial nits, remove trailing "." from list items - Update Charter history
Proposed one more change 0ca6676, while not strictly editorial, rolled it into this branch for convenience. |
Both Ambient Light Sensor and Proximity Sensor specs are now based on the Generic Sensor API and published on the Standards Track.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggesting an additional fix, but otherwise lgtm
DeviceAPICharter.html
Outdated
@@ -48,7 +48,7 @@ | |||
|
|||
<h1 id="title">[DRAFT] Device and Sensors Working Group Charter</h1> | |||
|
|||
<p><em>This is a draft revised Device APIs Working Group (renamed Device and Sensors Working Group) charter for discussion. It has no standing. See also the <a href="https://www.w3.org/2016/03/device-sensors-wg-charter.html">charter under which the Device APIs Working Group</a> currently operates.</em></p> | |||
<p><em>This is a draft revised Device APIs Working Group (renamed Device and Sensors Working Group) charter for discussion. It has no standing. See also the <a href="https://www.w3.org/2016/03/device-sensors-wg-charter.html">charter under which the Device and Sensors Working Group</a> currently operates.</em></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe flip the first: Device APIs Working Group (renamed Device and Sensors Working Group) -> Device and Sensors Working Group (formerly known as Device APIs Working Group); or drop the mention of Device APIs completely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed fix 69ec9e9
@dontcallmedom, I pushed b265f79 to this branch since your previous comment, PTAL. |
still LGTM :) |
Feel free to merge. If I find other editorial changes I can open another PR. (btw. what is the DL to get editorial changes in?) |
it would be good to get all changes in before next Tuesday, so that we can bring this to W3C management review next Wednesday |
PTAL @dontcallmedom