Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "posture modes" to "posture types" #64

Closed
beaufortfrancois opened this issue Mar 16, 2021 · 5 comments · Fixed by #68
Closed

Rename "posture modes" to "posture types" #64

beaufortfrancois opened this issue Mar 16, 2021 · 5 comments · Fixed by #68

Comments

@beaufortfrancois
Copy link
Contributor

As the DevicePosture interface has now a member called type, we may want to rename posture modes to "posture types" for consistency.
What do you folks think about it?

interface DevicePosture : EventTarget {
  readonly attribute DevicePostureType type;
  ...
};
@anssiko
Copy link
Member

anssiko commented Mar 17, 2021

I think this was addressed by #65 (thanks @beaufortfrancois for that PR!).

@anssiko anssiko closed this as completed Mar 17, 2021
@beaufortfrancois
Copy link
Contributor Author

It was not addressed by #65. This issue is about renaming the "posture modes" in https://w3c.github.io/device-posture/#posture-modes to "posture types".

@anssiko anssiko reopened this Mar 17, 2021
@anssiko
Copy link
Member

anssiko commented Mar 17, 2021

Sorry for being trigger-happy, reopened.

@darktears
Copy link
Contributor

I don't have a strong preference but if we were to be consistent, we should use "modes" in my opinion. Samsung and other folks have been using terms like "tent mode" or "flex mode" and I regularly hear people saying "being used as laptop mode".

@kenchris
Copy link
Contributor

I think it should be Type as it's an enum. Would be consistent with Orientation lock spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants