-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define resolution function with data types, property values, and simple metadata structures #298
Define resolution function with data types, property values, and simple metadata structures #298
Conversation
conform to valid syntax. (See <a href="#did-syntax"></a>.) | ||
</dd> | ||
<dt> | ||
unauthorized |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting... I would expect this code to be surfaced by an http / transport, but not by a functional interface.
This feels like transport logic leaking into the contract interface, it also seems to leak some privacy information, I would rather just get a 404 from the method resolver for such cases, but I may not have interpreted this correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is just one of many possible error conditions that the function could return. I thought of a couple that seemed obvious and common, but if this one is potentially controversial than it can be removed from this PR set. It's more important that there be a place to list and return error values that the group can then expand as use cases require them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you covered this on the call, and as long as the working group understands that git is not append only, and we can and will refactor, i see no reason to block this PR...
this <a>DID resolver</a>. | ||
</dd> | ||
<dt> | ||
not-found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exceedingly common, eager to see use this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about unauthorized, but the rest of this seems good to me.
I'd suggest removing unauthorized error for now or adding a link to an issue so we can discuss further without cluttering the PR.
This adapts the DID Resolution functional definition defined by #253 into a single typed function with requirements for the function signature and implementation conformance. Property values for input and output metadata structures are defined here, with pointers to the DID registry for management of properties. Requirements for when and how to return each value are also added.
Simple metadata structures are defined here, without detail for conformance or transmission.
This builds on #295, #296, and #297.
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on May 27, 2020, 9:28 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.