Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry Updates #132

Closed
wants to merge 5 commits into from
Closed

Conversation

OR13
Copy link
Contributor

@OR13 OR13 commented Sep 18, 2020

  • Remove @context from "Base Properties"
  • Rename "Base Properties" to "Core Properties" add link to did core.
  • Remove publicKey (no longer defined in DID Core)
  • Remove publicKeyPem
  • Remove "created" + "updated" from core jsonld context.
  • Remove "didv" from core jsonld context.

Preview | Diff

@OR13 OR13 requested a review from msporny as a code owner September 18, 2020 00:05
Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught two things... don't expect them to take long to sort out.

@@ -16,7 +15,6 @@
"RsaVerificationKey2018": "sec:RsaVerificationKey2018",
"SchnorrSecp256k1VerificationKey2019": "sec:SchnorrSecp256k1VerificationKey2019",
"X25519KeyAgreementKey2019": "sec:X25519KeyAgreementKey2019",
"ServiceEndpointProxyService": "didv:ServiceEndpointProxyService",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something that's important to Veres One, and I expect, other DID Methods once people fully grasp GDPR and how it impacts DID Method implementers. We're waiting for the Service Endpoint discussion to settle before proposing it. It's fine that it's removed now and awaits a definition of it, but I want to be crystal clear that removing it at this point DOES NOT imply that it was never here or that we do not intend to define it in DID Core.

/cc @dlongley @dmitrizagidulin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like something to discuss on a special topic call, about services.

"publicKeyJwk": {
"@id": "sec:publicKeyJwk",
"@type": "@json"
},
"service": {
"@id": "didv:service",
"@id": "https://www.w3.org/TR/did-core/#dfn-services",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, this looks incorrect. Defining vocabulary IDs in DID Core could be done, but I suggest that we don't want to do that. Let's have a clean vocabulary file... that file is located at: https://www.w3.org/ns/did and the representation of that resource is the DID Spec Registries document.

So, the URL should be https://www.w3.org/ns/did#service.

"@type": "@id",
"@container": "@set"
},
"serviceEndpoint": {
"@id": "didv:serviceEndpoint",
"@id": "https://www.w3.org/TR/did-core/#dfn-service-endpoints",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as above.

@OR13 OR13 closed this Oct 1, 2020
@msporny msporny deleted the feat/remove-context-from-core-properties branch November 14, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants