Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to editorial notes and change notes in ttl file #926

Merged
merged 11 commits into from
May 14, 2019
Merged

Conversation

davebrowning
Copy link
Contributor

@davebrowning davebrowning commented May 12, 2019

in line with #919... and #920.

Remove editorialNotes marking work in progress
Align change notes with the work in #919

@davebrowning
Copy link
Contributor Author

This should only get merged after #919 has been merged.

Question: should the ttl file have an entry for dct:location since we have one for dct:PeriodOfTime?

@davebrowning davebrowning marked this pull request as ready for review May 12, 2019 17:09
@dr-shorthair
Copy link
Contributor

My view is that we should mention every class and property that is 'recommended for use'.
WHere these have usage notes or definitions in context that vary at all from the originator's, these should also be included as skos:definition and skos:scopeNote.

@agbeltran
Copy link
Member

I agree with @dr-shorthair's point.

@davebrowning
Copy link
Contributor Author

davebrowning commented May 13, 2019

Thanks - I've done that now (though since I don't have any support for ttl syntax someone should have a check....)

I also think that this lines up with #919 (as it did before) but re-checking all the notes etc can perhaps wait till its time to merge this.....

Copy link
Contributor

@dr-shorthair dr-shorthair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a syntax check.

Copy link
Contributor

@pwin pwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look ok

@pwin pwin merged commit b08d277 into gh-pages May 14, 2019
@davebrowning davebrowning deleted the dcat-ttl-ednote2 branch May 16, 2019 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants