Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compositing-1] CR Draft of Compositing-1 #443

Closed
2 tasks done
svgeesus opened this issue Nov 23, 2021 · 13 comments
Closed
2 tasks done

[compositing-1] CR Draft of Compositing-1 #443

svgeesus opened this issue Nov 23, 2021 · 13 comments

Comments

@svgeesus
Copy link
Contributor

svgeesus commented Nov 23, 2021

It is long past time for a Candidate Recommendation Draft of Compositing-1. The previous publication was Jan 2015

I noticed a couple of issues that should be cleared up before that:

  • The Changes section lists "The following changes were made relative to the Candidate Recommendation of 20 February 2014:" but the previous publication was 2015 and has the same changes section. Changes should be updated for Changes since the 2015 CR
  • One of the editors, Rick Cabanier, is not in the CSS WG or SVG WG so should be moved to former Editor
@chrishtr
Copy link
Contributor

+1 to doing this work. I've been lax myself but would like to help.

@svgeesus
Copy link
Contributor Author

Thanks @chrishtr

In terms of keeping a changes section up-to-date, meaningful git commit messages are a big help. I don't know if you are using some sort of toolchain that does this, but a commit message of "none" means that each commit needs to be carefully examined to see what it actually changed.

@svgeesus
Copy link
Contributor Author

svgeesus commented Mar 7, 2024

So I added changes since the 2015 CR and I checked just now against the History and they are up to date.

I also moved Rik and Nikos (they are not in CSS WG or SVG WG) to former editor, just now. Those were the only publication blockers.

So we should publish a CR Draft.

@svgeesus
Copy link
Contributor Author

svgeesus commented Mar 7, 2024

@astearns Agenda+ for a publication decision, updated CR Draft. The previous publication was a CR in Jan 2015!!

@svgeesus
Copy link
Contributor Author

svgeesus commented Mar 7, 2024

Ah, I see also @fantasai said, in an unrelated issue:

I think mix-blend-mode should be animatable. I suspect what happened is that the reformatting of ”Animatable” to “Animation type” didn't catch the compositing spec because it's in the FXTF repo, and it's really supposed to be “discrete”.

which relates to

@svgeesus
Copy link
Contributor Author

svgeesus commented Mar 7, 2024

Animation type is fixed by 402eece

@svgeesus
Copy link
Contributor Author

svgeesus commented Mar 7, 2024

Oh and I updated the test status, which was wildly out of date (65 manual tests, unmaintained)

image

by adding wpt annotations, so now we have (225 tests, run every day)

image

@astearns
Copy link
Member

astearns commented Mar 8, 2024

The CSSWG will automatically accept this resolution one week from now if no objections are raised here. Anyone can add an emoji to this comment to express support. If you do not support this resolution, please add a new comment.

Proposed Resolution: Publish an updated CRD of compositing-1

@astearns
Copy link
Member

RESOLVED: Publish an updated CRD of compositing-1

@svgeesus
Copy link
Contributor Author

Publication requested 16 March, expected 21 March

@svgeesus
Copy link
Contributor Author

@astearns which edits are needed?

@astearns
Copy link
Member

Sorry, I added the tag thinking of publication as an “edit”

@svgeesus
Copy link
Contributor Author

Published 21 March 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants