Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [Exposed] to all interfaces #63

Closed
annevk opened this issue Sep 15, 2017 · 5 comments
Closed

Add [Exposed] to all interfaces #63

annevk opened this issue Sep 15, 2017 · 5 comments

Comments

@annevk
Copy link
Member

annevk commented Sep 15, 2017

Needed for whatwg/webidl#365.
@sgraham
Copy link
Contributor

sgraham commented Feb 14, 2018

I'm not familiar with this annotation, but I'm happy to merge any additions that fix some presentation issue.

@annevk
Copy link
Member Author

annevk commented Feb 16, 2018 •
edited
Loading

It's not a presentation issue; it defines on which globals your interfaces are defined/exposed.

@sagoston
Copy link
Contributor

sagoston commented May 3, 2018

We're not familiar with [Exposed] but I believe we only rely on Window (Window.navigator) in one place.

Could you create a PR for this issue?

@sagoston
Copy link
Contributor

sagoston commented May 8, 2018

Added Exposed to all interfaces.

@annevk Can you please take a look and let us know if this is sufficient?

@annevk
Copy link
Member Author

annevk commented May 8, 2018

Yeah, thanks. I recommend including the issue in the commit message in the future, makes it easier to find the change.

@annevk annevk closed this as completed May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sgraham @annevk @sagoston