Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate mapping sections are showing up #360

Closed
scottaohara opened this issue Jan 20, 2022 · 5 comments
Closed

duplicate mapping sections are showing up #360

scottaohara opened this issue Jan 20, 2022 · 5 comments

Comments

@scottaohara
Copy link
Member

Something quirky must be going on with the scripts where a second mapping section for both the HTML elements and attributes are now being created.

@jnurthen or @spectranaut maybe we could look at this when we've some overlapping 'free' time?

i imagine the solution here will be to use all the aria-common scripts, and might be best to wait until w3c/core-aam#102 is resolved?

@spectranaut
Copy link
Contributor

Wow this is very odd... and since I'm looking at the same code for core-aam, I'm happy to take a look here too!

@scottaohara
Copy link
Member Author

much appreciated @spectranaut

@spectranaut
Copy link
Contributor

spectranaut commented Jan 21, 2022

Ok, so I looked into it! It turns out mappingTables is called twice: once when the js file is loaded (you can see the code at the top of the file, related to respec events, which are no longer supported, according to the discussion here: https://github.com/w3c/html-aam/blob/gh-pages/script/mapping-tables.js#L91), and once during the respec preprocessing.

I'm removing the onload running of mappingTables in the mapping-tables.js file in this pr over at core-aam: w3c/core-aam#105

These two files should be the same file, currently they are not, mostly do to weird code formatting differences as far as I can tell. Should we wait for the other PR to land and then copy the file here?

@scottaohara
Copy link
Member Author

yeah i'm fine with waiting on this. to be fair, no one has said anything...

if i'm looking at the head of this spec correctly, we really should be just calling all the scripts from aria-common instead of copying them here. i think the forking of the scripts happened when HTML AAM was part of w3c's html group and then the web apps group... but now that it's back in the ARIA WG we should have access to aria-common again?

... so yeh. long way of saying i'm fine with waiting. we can then try to just reference the common scripts instead of copying them here. and if that doesn't work, then copy them over.

@scottaohara
Copy link
Member Author

this was fixed and was actually due to some errant markup. closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants