document.domain setter is broken

[bzbarsky]

It always throws. Please compare to the whatwg version and fix.

[bzbarsky]

Note that the missing "end of" in step 7.2 is the obvious problem here, but there may be other issues; I didn't compare very carefully....

[stevefaulkner]

@bzbarsky so I am clear is the variance in the algorithm between
https://w3c.github.io/html/browsers.html#relaxing-the-same-origin-restriction and https://html.spec.whatwg.org/multipage/browsers.html#relaxing-the-same-origin-restriction ?

[bzbarsky]

Yes. The former is wrong; the latter is right.

[stevefaulkner]

@travisleithead @adanilo @cynthia et al, I compared the 2 document.domain setter algorithms from the URLs above and could not see any difference, can you review, thanks

[stevefaulkner]

note the 5.1 rec https://www.w3.org/TR/html51/browsers.html#relaxing-the-same-origin-restriction does not differ from the 5.2 working draft

[dontcallmedom]

in case this helps, here is the visual diff for this specific algo

generated by htmldiff (can't do it online, it seems to be too resource intensive)

The critical piece in the step 7.2. is that is missing the end of effectiveDomain.