Adding Autocapitalize #1072
Adding Autocapitalize #1072
Conversation
Regarding Issue #208
sections/semantics-forms.include
Outdated
| use on text fields. | ||
|
|
||
| It currently provides three different capitalization methods; <code>sentences</code>, | ||
| <code>words</code>, and <code>characters</code>. |
There was a problem hiding this comment.
Please provide a clear normative definition of each mode. Also, what happens if the attribute value is not one of those?
sections/semantics-forms.include
Outdated
| <input type="text" autocapitalize="characters"> | ||
|
|
||
| </div> | ||
|
|
There was a problem hiding this comment.
Please note the addition in the changes section (changes.include in the sections directory).
There was a problem hiding this comment.
New version updates the changes.include
sections/semantics-forms.include
Outdated
| <input type="text" autocapitalize="characters"> | ||
|
|
||
| </div> | ||
|
|
There was a problem hiding this comment.
Please list the attribute in the attributes.include file in the sections folder
There was a problem hiding this comment.
New version updates the attributes.include
|
Could you please link tests? (Even a description of a manual procedure...) |
|
Should there be a 4th valid option "none"? (to encourage no autocapitalisation by default)? |
Still not quite ready to merge
sections/attributes.include
Outdated
| <td><{input}></td> | ||
| <td>Hint for the capitalization of the inputted text</td> | ||
| <td>"<a attr-value for="input/autocapitalize"><code>sentences</code></a>"; "<a attr-value for="input/autocapitalize"><code>words</code></a>"; "<a attr-value for="input/autocapitalize"><code>characters</code></a>"</td> | ||
| </tr> |
There was a problem hiding this comment.
Please linebreak (yes, we're getting nitpicky here :) )
sections/changes.include
Outdated
| @@ -82,9 +84,9 @@ | |||
| <dt><a href="https://github.com/w3c/html/commit/49073d89a7829dc3dbbfc3802f38bf9845902117">Remove references to Polyglot Markup</a></dt> | |||
| <dd>Removes references to the Polyglot Markup specification (now published as a W3C Note).</dd> | |||
| <dt><a href="https://github.com/w3c/html/commit/0b959a586e54fe4145b69303ebb11755cea26c09">Make menu and menuitem match reality</a></dt> | |||
| <dd>Removes the radio and checkbox types for menus; requires that <{menuitem}> has content; <{menuitem}> makes a command if it is labelled; changes terminology from "popup menu" state to "context menu" state.</dd> | |||
| <dd>Removes the radio and checkbox types for menus; requires that <{menuitem}> has content; <{menuitem}> makes a command if it is labelled; changes terminology from "popup menu" state to "context menu" state.</dd> | |||
There was a problem hiding this comment.
(This could use a linebreak too while you're here...)
There was a problem hiding this comment.
Not sure where you want a linebreak...? Looks the same as the other sections to me.
Add (pro-forma) default (may change), describe what User Agents should do, ...
|
Still to do
|
Also remove proposed "" value - let the defaults deal with it.
|
Tested with iOS11/Safari and found that all tests passed for English. With the note that default behaviour on iOS is to switch to caps for the first character in a standard text input, so test 5 (sentences) passes by default. |
|
Hmm. This is close to "good enough for wide review". I'd like to be explicit that it is an enumerated attribute in the prose - see the autocomplete attribute as a model. And I am not sure about the defaults - on the one hand mobile browsers default to What will actually get implemented is pretty relevant... |
match reality...
don't forget this bit
(Probably more are due than this, but thanking some of the giants on whose shoulders we stand is better than thanking none)
My first time adding a section. Please feel free to tell me what I've done wrong and how I need to fix it.
Fixes #208