This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
Clarify requirements for progress elements #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #1024 * make "in/determinate progress bars" (which were used as terms) a proper defined term * refactor to gather requirements accordingly Hopefully clarify sufficiently that the behaviour depending on attribute order in source is obviously a bug.
chaals
requested review from
shwetank,
brucelawson,
edent and
patricia-gallardo
|
@Jinjiang does this make it clearer? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1024
proper defined term
order in source is obviously a bug.