Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Update header comment #1213

Merged
merged 3 commits into from Feb 17, 2018
Merged

Update header comment #1213

merged 3 commits into from Feb 17, 2018

Conversation

chaals
Copy link
Collaborator

@chaals chaals commented Feb 16, 2018

See also #1201

<!--
Embedded content

This source produces section 4.7: Embedded Content https://w3c.github.io/html/semantics-embedded-content.html#semantics-embedded-content
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want the #semantics-embedded-content at the end of the web address? otherwise looks good to me

Thanks @scottaohara for the review
@chaals
Copy link
Collaborator Author

chaals commented Feb 16, 2018

@scottaohara No, I didn't want that, thanks for picking it up.

(Not that it matters a lot either way, but seems cleaner without it). Waiting to check it builds clean, and then it can be merged I think.

Travis doesn't like the `-->` and thinks it needs indenting.
@chaals
Copy link
Collaborator Author

chaals commented Feb 17, 2018

Thanks @edent

@chaals chaals merged commit 3ab7d82 into master Feb 17, 2018
scottaohara pushed a commit that referenced this pull request Feb 17, 2018
* Update header comment in "embedded content"

See also #1201
@chaals chaals deleted the chaals-embedded-header-1201 branch February 28, 2018 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants