Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

add examples to u #1248

Merged
merged 1 commit into from
Feb 26, 2018
Merged

add examples to u #1248

merged 1 commit into from
Feb 26, 2018

Conversation

chaals
Copy link
Collaborator

@chaals chaals commented Feb 25, 2018

fix #1245

@chaals
Copy link
Collaborator Author

chaals commented Feb 25, 2018

ping @prlbr @programmer3000

@chaals chaals merged commit 41a1f84 into master Feb 26, 2018
@prlbr
Copy link
Contributor

prlbr commented Feb 26, 2018

Can you explain why <mark> would be better suited in the example cases as stated in this section? I do not see that.

<div class="example">
 Note that the examples above, and even more the following
  
 <xmp>
  <abbr>HTML</abbr> stands for <u>H</u>yper<u>t</u>ext <u>M</u>arkup <u>L</u>anguage.
 </xmp>

 could and probably should be written

 <xmp>
  <abbr>HTML</abbr> stands for <mark>H</mark>yper<mark>t</mark>ext <mark>M</mark>arkup <mark>L</mark>anguage.
 </xmp>
</div>

As for the wording, “probably should be” does not communicate the confidence I’d expect from a standard.

I think it’s fine to give alternatives when alternatives are equally valid.

In general, if one alternative is clearly preferred, I would just give an example for the preferred version.

In some cases it may be helpful to provide the less preferred version too in contrast to the preferred version in order to explain a point. We would need to add an explanation if this is the case here.

I think that if we add examples, we should definitely include an example that shows the preferred use first. Adding multiple examples and then saying that neither example shows how HTML should be done best is not helpful.

plehegar pushed a commit that referenced this pull request Feb 26, 2018
Chinese text (a Chinese proper name mark), or labeling the text as being misspelt.

The <{u}> element <a>represents</a> a span of text with a non-textual annotation,
such as labeling a proper name in Chinese text, a surname, or text as being misspelt.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the inclusion of these examples is confusing. I've never seen Chinese names being regularly underlined. I would remove this entire line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here’s a Wikipedia article about it: https://en.wikipedia.org/wiki/Proper_name_mark. Would be great to have input from China on this / gather data from chinese websites.


<div class="example">

Note that the examples above, and even more the following
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this sentence. It seems to end in the middle.

<abbr>HTML</abbr> stands for <u>H</u>yper<u>t</u>ext <u>M</u>arkup <u>L</u>anguage.
</xmp>

could and probably should be written
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should it probably be written this way?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, on reflection, because I was tired more than anything. I'll strip this bit out, and wait until we get some clarity in #1247 before playing with it again.

chaals added a commit that referenced this pull request Feb 26, 2018
Remove the contentious stuff - keep it simple for now.
scottaohara pushed a commit that referenced this pull request Feb 26, 2018
Remove the contentious stuff - keep it simple for now.
plehegar pushed a commit that referenced this pull request Feb 26, 2018
chaals pushed a commit that referenced this pull request Feb 26, 2018
@chaals chaals deleted the chaals-u-examples-1245 branch February 28, 2018 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants