Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

update to prose #1444

Merged
merged 2 commits into from
Jun 19, 2018
Merged

update to prose #1444

merged 2 commits into from
Jun 19, 2018

Conversation

scottaohara
Copy link
Member

fixes #1443

Adds note about elements described as transparent.

Other minor wording updates to the previous prose of this section.

fixes #1443

Adds note about elements described as transparent.

Other minor wording updates to the previous prose of this section.
@patricia-gallardo
Copy link
Contributor

In the new note I think it would be more easily understandable if it provided an example of how this could be used.

Copy link
Contributor

@patricia-gallardo patricia-gallardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an example on the new note

Copy link
Collaborator

@chaals chaals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question, request for less jargon-y prose

</p>

<p class="note">
An exception to disallowing <a>block box</a> within <a>inline box</a> rendered elements
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you call these something clearer? "elements that are typically rendered as a ..."?

(sorry, no better ideas right now)

</p>

<p class="note">
An exception to disallowing <a>block box</a> within <a>inline box</a> rendered elements
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only exception, or are there others (which is what seems to be implied here)?

@scottaohara
Copy link
Member Author

@patricia-gallardo & @chaals,
Added some quick examples and reworded/rearranged the prose a bit. I worry about adding too much more to this section of the introduction, so I make mention that people should refer to the elements called out here, and other transparent elements, for additional info.

@scottaohara
Copy link
Member Author

scottaohara commented Jun 4, 2018

@patricia-gallardo, @chaals any more that needed to be done on this?

@chaals
Copy link
Collaborator

chaals commented Jun 5, 2018

Looks good to me. @patricia-gallardo, if you are happy please merge this.

@chaals chaals merged commit f22a13d into master Jun 19, 2018
@scottaohara scottaohara deleted the so_1443 branch June 19, 2018 14:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HTML Intro: Cases where the default styles are likely to lead to confusion
4 participants