Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example structure 'total' not localizable? #1412

Closed
aphillips opened this issue Sep 9, 2021 · 3 comments
Closed

Example structure 'total' not localizable? #1412

aphillips opened this issue Sep 9, 2021 · 3 comments
Labels
s:secure-payment-confirmation https://w3c.github.io/secure-payment-confirmation

Comments

@aphillips
Copy link
Contributor

Example 2 under 1.2.2. Authentication
https://w3c.github.io/secure-payment-confirmation/#sctn-sample-authentication

    total: {
      label: "Total",
      amount: {
        currency: "USD",
        value: "5.00",
      },
    },

The string label contains natural language text without language/direction information. While it is probably beyond the scope of SCP to discuss how localization or language negotiation takes place within a given bit of JS, it's probably a good idea to show examples that follow best practices.


Instructions:

This follows the process at https://w3c.github.io/i18n-activity/guidelines/review-instructions.html

  1. CREATE A PROPOSED REVIEW COMMENT BY REPLACING THE PROMPTS ABOVE THIS PARAGRAPH, BUT LEAVE THIS PARAGRAPH INTACT AS WELL AS THE TEXT BELOW IT Then ask the i18n WG to review your comment.

  2. Set a label to identify the spec. This starts with s: followed by the spec's short name. If you are unable to do that, ask a W3C staffer to help.

  3. After discussion with the i18n WG, raise this issue to the WG that owns the spec. Use the text above this para as the basis for that comment.

  4. Replace the text 'link_to_issue_raised' below with a link to the place you raised the issue. Do NOT remove the initial '§ '.

  5. Edit this issue to remove this paragraph and ALL THE TEXT ABOVE IT.

  6. Remove the 'pending' label.

This is a tracker issue. Only discuss things here if they are i18n WG internal meta-discussions about the issue. Contribute to the actual discussion at the following link:

§ link_to_issue_raised

@aphillips aphillips added pending Issue not yet sent to WG, or raised by tracker tool & needing labels. s:secure-payment-confirmation https://w3c.github.io/secure-payment-confirmation labels Sep 9, 2021
@xfq
Copy link
Member

xfq commented Sep 11, 2021

nit: "SCP" -> "SPC"

@himorin
Copy link
Contributor

himorin commented Feb 10, 2022

This dictionary is defined as PaymentItem in Payments Request spec.

@aphillips aphillips removed the pending Issue not yet sent to WG, or raised by tracker tool & needing labels. label May 10, 2022
@aphillips
Copy link
Contributor Author

Closing as rejected. This issue might be dealt with when we resolve language negotiation and handling of natural language text. For now it is not actionable by SPC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:secure-payment-confirmation https://w3c.github.io/secure-payment-confirmation
Projects
None yet
Development

No branches or pull requests

3 participants