Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css-sizing-3 2020-10-23 > 2020-12-01 #133

Closed
fantasai opened this issue Oct 23, 2020 · 2 comments
Closed

css-sizing-3 2020-10-23 > 2020-12-01 #133

fantasai opened this issue Oct 23, 2020 · 2 comments
Assignees
Labels
close? LC Working Draft approaching CR. REVIEW REQUESTED

Comments

@fantasai
Copy link

Review request for CSS Sizing Level 3 https://www.w3.org/TR/css-sizing-3/

  • What and when is your next expected transition? To CR soon-ish.
  • What has changed since any previous review? A lot of sizing algorithm details.
  • Any information arising from a self-review? None
  • Where and how to file issues arising? In CSSWG GH https://github.com/w3c/csswg-drafts/issues
  • Pointer to any explainer for the spec? None

Other comments:

This CSS module defines the various sizing properties and concepts used throughout CSS. New features since CSS2 are summarized in
https://www.w3.org/TR/css-sizing-3/#changes-3

We've already defined all the algorithms in flow-relative terms, so I don't expect internationalization to have much to add.

This spec is helpful to internationalization because enabling better control over content-based sizing as we're doing here makes pages more robust to translation.

@fantasai fantasai added LC Working Draft approaching CR. REVIEW REQUESTED pending The WG needs to assign a reviewer. labels Oct 23, 2020
@aphillips aphillips removed the pending The WG needs to assign a reviewer. label Nov 5, 2020
@himorin
Copy link
Contributor

himorin commented Nov 11, 2020

This spec uses horizontal/vertical writing mode related definitions (e.g. aspect ratio, inline/block size), but these are defined by writing mode aware way (spec is not specifically mentioned in the text, but terminology refers to css-writing-mode as term-ref link) as figure 1, whose images seem to be taken from css-writing-mode.

Therefore, no i18n related issue was found.
But it could be better for readers to have some text like CSS Writing Modes’ Abstract Box Terminology (from css-logical, introduction section) in section 2. terminology.

@aphillips
Copy link
Contributor

I18N has completed a review of Sizing Level 3 and found no new issues. Thank you for requesting a review!

@r12a r12a closed this as completed Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
close? LC Working Draft approaching CR. REVIEW REQUESTED
Development

No branches or pull requests

4 participants