Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Generate PR #332
Pierre, we should probably have a diff betwwen CR version and PR version, showing no substantial changes. maybe a simple diff from the diff tool is enough https://services.w3.org/htmldiff?doc1=https%3A%2F%2Fwww.w3.org%2FTR%2F2017%2FCR-ttml-imsc1.0.1-20170713%2F&doc2=http%3A%2F%2Frawgit.com%2Fw3c%2Fimsc%2FIMSC1.0.1-PR%2Fimsc1%2Fspec%2Fttml-ww-profiles.html Thierry…
On 12/02/2018 17:16, Pierre-Anthony Lemieux wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------ In imsc1/spec/ttml-ww-profiles.html <#332 (comment)>: > <p>A list of the substantive changes applied since the <a href="https://www.w3.org/TR/2017/WD-ttml-imsc1.0.1-20170322/">initial Working Draft</a> is found at <a href="substantive-changes-summary.txt">substantive-changes-summary.txt</a>.</p> - <p>This revision of the document is designed such that <a data-lt="processor">Processors</a> and <a data-lt= - "document instance">document instances</a> that conform to the <a href= - "http://www.w3.org/TR/2016/REC-ttml-imsc1-20160421/">Recommendation dated 21 April 2016</a> also conform to this revision. As a The scope states: /This version of the specification makes editorial corrections and adds two optional features (6.7.5 ittp:activeArea and 6.7.6 itts:fillLineGap) over the Recommendation dated 21 April 2016. Processors and document instances that conform to the Recommendation dated 21 April 2016 also conform to this version of the specification./ — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#332 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGiYfotp7zSk6UaFs1RlYsiXtqbCOa60ks5tUGPygaJpZM4SANg_>.
Pierre, During CR publication we have already give a diff between CR and REC. We should have a diff between CR and PR to show that there are no substantives changes since CR. We will need it for Request for transition to PR. But you can leave both diff. Thierry…
On 12/02/2018 17:39, Pierre-Anthony Lemieux wrote: @tmichel07 <https://github.com/tmichel07> Is a diff wrt to the CR required /in addition to/ or /instead of/ the diff wrt to the previous REC? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#332 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGiYfiuKha2_ps_BxTPcCp6yKXc1uP40ks5tUGlEgaJpZM4SANg_>.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.