Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate PR #332

Closed
wants to merge 4 commits into from
Closed

Generate PR #332

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d65a816
Generate PR (#310)
palemieux Feb 9, 2018
b8735a2
Address comments
palemieux Feb 9, 2018
bdbc0dc
Addresses https://github.com/w3c/imsc/pull/332#issuecomment-364993616
palemieux Feb 12, 2018
0ad03b3
Merge remote-tracking branch 'origin/master' into IMSC1.0.1-PR
palemieux Feb 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion imsc1/spec/manifest.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
ttml-ww-profiles.html respec
diff.html
substantive-changes-summary.txt
xml-schemas/index.html
xml-schemas/imsc1.xsd
Expand All @@ -8,6 +7,7 @@ xml-schemas/imsc1-metadata.xsd
xml-schemas/imsc1-parameters.xsd
xml-schemas/imsc1-styling.xsd
figures/fillLineGap-example-figure-1.png
figures/fillLineGap-example-figure-2.png
figures/forced-example-figure-1.png
figures/hypothetical-render-figure-1.png
figures/text-render-example-figure-2.png
8 changes: 7 additions & 1 deletion imsc1/spec/substantive-changes-summary.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,10 @@ From WD (20170322)

- clarified requirement that regions are contained within root container (#239)

- clarified syntax of ittp:activeArea (#221)
- clarified syntax of ittp:activeArea (#221)

From CR (20170713)
==================

- clarified that the TTML1 style resolution procedure applies to extension style properties
defined in this specification (#300)
37 changes: 15 additions & 22 deletions imsc1/spec/ttml-ww-profiles.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,16 @@
</script>
<script class='remove'>
var respecConfig = {
specStatus: "ED"
, processVersion: "2017"
, previousMaturity: "WD"
, publishDate: "2017-07-13"
, crEnd: "2017-08-13"
specStatus: "PR"
, processVersion: "2018"
, previousMaturity: "CR"
, publishDate: "2018-02-20"
/*, errata: "http://www.w3.org/2016/04/ttml-imsc1-errata.html"*/
, crEnd: "2018-02-15"
, prEnd: "2018-03-20"
, implementationReportURI: "https://www.w3.org/wiki/TimedText/IMSC1_0_1_Implementation_Report"
, sotdAfterWGinfo: "true"
, previousPublishDate: "2017-03-22"
, previousPublishDate: "2017-07-13"
, shortName: "ttml-imsc1.0.1"
, otherLinks: [{
key: 'Latest IMSC1 recommendation',
Expand Down Expand Up @@ -87,26 +88,18 @@
</section>

<section id='sotd'>
<p>For this specification to exit the CR stage, at least 2 independent implementations of every feature defined in this
specification but not already present in [[IMSC1]] need to be documented in the implementation report. The implementation
report is based on implementer-provided test results for the <a href=
"https://www.w3.org/AudioVideo/TT/IMSC/ttml-imsc1.0.1/testsuite/">exit criteria test suite</a>. The Working Group does not
require that implementations are publicly available but encourages them to be so.</p>The Working Group has not identified
features "at risk" for this specification.
<p>The <a href="https://www.w3.org/wiki/TimedText/IMSC1_0_1_Implementation_Report">implementation report</a> documents that
there is at least 2 independent implementations for every feature defined in this specification but not already present in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "there are at least 2"

[[TTML1]], thereby satisfying the <a href="https://www.w3.org/AudioVideo/TT/IMSC/ttml-imsc1.0.1/testsuite/">exit criteria test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely it's "but not already present in [[IMSC1]]"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the words "test suite"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It already says: "exit criteria test suite"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was thinking we could remove "test suite", since the important point is that the exit criteria have been satisfied, not that the test suite has been satisfied..

suite</a>.</p>

<p>A list of the substantive changes applied since the <a href="https://www.w3.org/TR/2017/WD-ttml-imsc1.0.1-20170322/">initial
Working Draft</a> is found at <a href="substantive-changes-summary.txt">substantive-changes-summary.txt</a>.</p>

<p>This revision of the document is designed such that <a data-lt="processor">Processors</a> and <a data-lt=
"document instance">document instances</a> that conform to the <a href=
"http://www.w3.org/TR/2016/REC-ttml-imsc1-20160421/">Recommendation dated 21 April 2016</a> also conform to this revision. As a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we allowed to keep the first sentence in? I think it remains useful.

Copy link
Contributor Author

@palemieux palemieux Feb 9, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nigelmegitt This is already stated in the scope. I do not think it makes sense to repeat it in the SOTD, which should really be about the status of the document.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@palemieux I cannot see it in the scope section - at least in the version of the document in this pull request.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scope states: This version of the specification makes editorial corrections and adds two optional features (6.7.5 ittp:activeArea and 6.7.6 itts:fillLineGap) over the Recommendation dated 21 April 2016. Processors and document instances that conform to the Recommendation dated 21 April 2016 also conform to this version of the specification.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, not sure why I missed that before, thanks for the pointer.

result, review should focus on the modifications made since the <a href=
"http://www.w3.org/TR/2016/REC-ttml-imsc1-20160421/">Recommendation dated 21 April 2016</a>, including the <a href=
"#ittp-activeArea"></a> and <a href="#itts-fillLineGap"></a> features.</p>

<p>For convenience, a complete diff between this version and the <a href=
"http://www.w3.org/TR/2016/REC-ttml-imsc1-20160421/">Recommendation dated 21 April 2016</a> is found at <a href=
"diff.html">diff.html</a>.</p>
<p>For convenience, a diff between this version and the <a href=
"http://www.w3.org/TR/2016/REC-ttml-imsc1-20160421/">Recommendation dated 21 April 2016</a> is offered at the <a href=
"https://services.w3.org/htmldiff?doc1=http%3A%2F%2Fwww.w3.org%2FTR%2F2016%2FREC-ttml-imsc1-20160421%2F&doc2=https%3A%2F%2Fwww.w3.org%2FTR%2F2018%2FPR-ttml-imsc1.0.1-20180220%2F">
W3C HTML Diff service</a>.</p>
</section>

<section id='scope'>
Expand Down