Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing condition in section 3.3.8, first "f." #15

Closed
emuller-amazon opened this issue Dec 22, 2017 · 5 comments
Closed

Missing condition in section 3.3.8, first "f." #15

emuller-amazon opened this issue Dec 22, 2017 · 5 comments
Assignees
Labels
jlreq-doc:errata [JLReq-doc] errata fix items for 2nd edition

Comments

@emuller-amazon
Copy link

Section 3.3.8, first set of a., b., c., etc.

f. When the adjacent character is one of the closing brackets (cl-02), the ruby text may...
...
h. Also, when the adjacent character is one of the opening brackets (cl-01) before the ruby object, the ruby text may...

f. fails to say this is only when the bracket is after the ruby object h. does indicate this corresponding restriction (before the ruby object)

So, at the very least, insert "after the ruby object" after "(cl-02)" in f.

Even better, I think that f, g and h can be combined:

When the preceding character is an opening bracket, or when the following character is a closing bracket, a comma or a full stop, the ruby text may go over these adjacent characters, up to the full-width size of a ruby character. Note that the overhang must not go beyond those adjacent characters.

@r12a r12a added the jlreq-doc:errata [JLReq-doc] errata fix items for 2nd edition label Sep 28, 2018
@himorin
Copy link
Contributor

himorin commented May 13, 2019

Toshi Kobayashi san updated text of f,g,h by combining into one.

@macnmm
Copy link
Contributor

macnmm commented Jun 11, 2019

@himorin I have some edits to make over the entire ruby section's English. Should we close this issue out first, or should I address the whole section as well as the few lines involved in this issue?

@himorin
Copy link
Contributor

himorin commented Jun 17, 2019

I'd want to have an issue for edits over the entire this section first, also I don't think closing this without fix is a good way.

@macnmm
Copy link
Contributor

macnmm commented Jun 17, 2019

OK I was able to separate out the fix for #10. However in re-wording the fix for #15, I changed "ruby letter" to "ruby character", and "go over" to "overhang". This introduced inconsistencies in all the places where the former phrases are used. So, I unified on the phrases I prefer. That is why the #15 change covers more areas. So, this time I can use the "letter" and "go over" phrasing in my smaller change and create an issue about "letter" and "go over" to clean up further in another PR...

@himorin
Copy link
Contributor

himorin commented Jun 18, 2019

initial target point fixed and merged, closing this issue

@himorin himorin closed this as completed Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jlreq-doc:errata [JLReq-doc] errata fix items for 2nd edition
Projects
None yet
Development

No branches or pull requests

4 participants