Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect interpretation in 2.5.2 Line Positioning based on the Kihon-hanmen Design #10

Closed
kojiishi opened this issue Aug 4, 2017 · 3 comments
Assignees
Labels
jlreq-doc:errata [JLReq-doc] errata fix items for 2nd edition

Comments

@kojiishi
Copy link
Contributor

kojiishi commented Aug 4, 2017

The item a (the first list item) of 2.5.2 Line Positioning based on the Kihon-hanmen Design says:

The former approach is used, whenever possible, to achieve inter-character spacing before and after illustrations or tables constant.

but as in the following figure 2.41, this is talking about "the same amount of gaps between text and illustrations."

Suggest to change "inter-character spacing" to "inter-object spacing", or just "spacing".

@macnmm
Copy link
Contributor

macnmm commented Sep 27, 2018

I agree with "spacing". Also, I think it may be good to state that the inter-object spacing is often related to the kihon hanmen text grid, in that space is in even multiples or fractions of the text grid size, and aligned to the embox (virtual body) of that text grid in some way. I am thinking also of how grid "snapping" as the layout is updated should happen in both x and y directions; the example in jlreq look to me to be primarily y direction only.

@r12a r12a added the jlreq-doc:errata [JLReq-doc] errata fix items for 2nd edition label Sep 28, 2018
@himorin
Copy link
Contributor

himorin commented May 13, 2019

@macnmm
Copy link
Contributor

macnmm commented May 21, 2019

should we assign this to me to take forward? I cannot assign myself... @himorin

@macnmm macnmm self-assigned this May 21, 2019
macnmm added a commit that referenced this issue Jun 11, 2019
Made tweaks to the English describing spacing between figures and text in book layout from 2.5.2
@macnmm macnmm closed this as completed in 363c987 Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jlreq-doc:errata [JLReq-doc] errata fix items for 2nd edition
Projects
None yet
Development

No branches or pull requests

4 participants