modified all #217
Merged
modified all #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r12a
approved these changes
Jun 11, 2020
kidayasuo
reviewed
Jun 11, 2020
| <p its-locale-filter-list="en" lang="en">Small-headings are sometimes set with a Japanese gothic face and smaller character size than the character size of the main text. For example, for 8 point mincho main text, set the small-headings with 8 point Japanese gothic.</p> | ||
| <p its-locale-filter-list="en" lang="en">Low level headings are sometimes set with a Japanese gothic face and smaller character size than the character size of the main text. For example, for 8 point mincho main text, set the low level headings with 8 point Japanese gothic.</p> |
There was a problem hiding this comment.
As we are making heading names consistent, i.e. top, medium and small, I am not sure if this change makes sense. There are a few other similar changes.
There was a problem hiding this comment.
#120 (comment) says top/medium/low... (and pending low or small?)
There was a problem hiding this comment.
oh, you are right. It is top, medium and low. Please ignore my comment.
kidayasuo
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #120
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Jun 11, 2020, 10:00 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.