Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix English in fix for Missing condition in section 3.3.8, first "f." #15 #68

Closed
wants to merge 2 commits into from
Closed

fix English in fix for Missing condition in section 3.3.8, first "f." #15 #68

wants to merge 2 commits into from

Conversation

macnmm
Copy link
Contributor

@macnmm macnmm commented Jun 17, 2019 •
edited by pr-preview bot

tweak description of ruby spacing

Preview | Diff

@macnmm
fix english: #10
d1f33ed 
Made tweaks to the English describing spacing between figures and text in book layout from 2.5.2
@macnmm
fix typo, also wording of “spaces between characters” to “inter-chara…
b954d4a 
…cer spacing”
@macnmm macnmm requested a review from himorin June 17, 2019 19:44
himorin
himorin requested changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@himorin himorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems first part is #66 , and better to be removed from this PR.

@macnmm
Copy link
Contributor Author

macnmm commented Jun 19, 2019

closing and replacing with more accurate PR, and CL branching off main.

@macnmm macnmm closed this Jun 19, 2019
@macnmm macnmm deleted the macnmm/fix15 branch June 19, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himorin himorin himorin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@macnmm @himorin