Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete conditional when determining error case in Create Term Definition #261

Closed
kasei opened this issue Dec 19, 2019 · 3 comments
Closed

Comments

@kasei
Copy link

@kasei kasei commented Dec 19, 2019

Create Term Definition step 28 says:

If the value contains any entry other than @id, @reverse, @container, @context, @language, @nest, @prefix, or @type, an invalid term definition error has been detected and processing is aborted.

I believe this list is missing several valid values:

  • @direction, as step 25 uses this as a key:

If value contains the entry @direction and does not contain the entry @type

  • @protected, as step 11 uses this as a key:

If the @protected entry in value is true set the protected flag in definition to true.

  • @index, as step 22 uses this as a key:

If value contains the entry @index

@iherman

This comment has been minimized.

Copy link
Member

@iherman iherman commented Dec 20, 2019

This issue was discussed in a meeting.

  • RESOLVED: Agree missing keywords in step 28, accept pchampin’s PR #267, and close
View the transcript @direction etc missing in step 28
Rob Sanderson: #261
Rob Sanderson: This issue is more extensive.
… The Create Term Definition lists a few keywords, but some are missing.
… pchampin also has a PR for this.
Proposed resolution: Agree missing keywords in step 28, accept pchampin’s PR #267, and close (Rob Sanderson)
Gregg Kellogg: +1
Rob Sanderson: +1
Ruben Taelman: +1
Tim Cole: +1
Jeff Mixter: +1
Pierre-Antoine Champin: +1
Resolution #5: Agree missing keywords in step 28, accept pchampin’s PR #267, and close
@azaroth42 azaroth42 moved this from Discuss-Call to Editorial Work in JSON-LD Management Dec 20, 2019
@gkellogg

This comment has been minimized.

Copy link
Member

@gkellogg gkellogg commented Dec 20, 2019

@kasei changes made in PR #267, please acknowledge resolution.

@gkellogg gkellogg added wr:pending and removed wr:open labels Dec 20, 2019
@gkellogg gkellogg moved this from Editorial Work to Editorial work complete in JSON-LD Management Dec 21, 2019
@kasei

This comment has been minimized.

Copy link
Author

@kasei kasei commented Dec 22, 2019

@gkellogg yes, looks good. Thanks.

@gkellogg gkellogg closed this Dec 23, 2019
@gkellogg gkellogg removed this from Editorial work complete in JSON-LD Management Dec 23, 2019
kasei added a commit to kasei/perl-jsonld that referenced this issue Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.