Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for #99: Framing matches on specified value #100

Conversation

michaelcpuckett
Copy link
Contributor

@michaelcpuckett michaelcpuckett commented Mar 2, 2020

I noticed a discrepancy between JSON-LD Playground and RDF Distiller regarding frame matching.

This PR adds 3 tests for frame matching on a specified value.

Fixes #99

Original issue here:

digitalbazaar/jsonld.js#300

I created a fix for this in jsonld.js repo and the I'm hoping to commit the tests here.

@michaelcpuckett
Copy link
Contributor Author

One check has failed. I joined the JSON-LD group a few days ago but it's reporting that I haven't, I think. https://www.w3.org/users/121373

@iherman
Copy link
Member

iherman commented Mar 2, 2020

Admin note: even in case of acceptance, this PR does not produce substantive (ie, IPR related) changes in the spec, so I set the checks accordingly.

@iherman
Copy link
Member

iherman commented Mar 2, 2020

Marked as non substantive for IPR from ash-nazg.

@iherman
Copy link
Member

iherman commented Mar 2, 2020

One check has failed. I joined the JSON-LD group a few days ago but it's reporting that I haven't, I think. https://www.w3.org/users/121373

Unfortunately, this is more complicated...

  • first of all, for our checks to combine the github event with W3C specific issues you have to manually 'connect' your W3C account with the github id. This can be done if you go to your W3C profile page above, and check the appropriate menu item on the left hand bar.

  • however, to be a bona fide JSON WG member, your institution must be a W3C member, and this institution would then 'delegate' you to the Working Group. And, I'm afraid, your employer is not a W3C member...

Anyway, your contribution is not affecting IPR (the main reason of all this check on the PR), and I so noted. So your PR is o.k.

@gkellogg
Copy link
Member

gkellogg commented Mar 2, 2020

Tests look good, thanks!

@gkellogg gkellogg requested a review from davidlehn March 2, 2020 23:50
@gkellogg
Copy link
Member

gkellogg commented Mar 2, 2020

Fixes #99.

@gkellogg gkellogg merged commit ab40dc8 into w3c:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need tests for: Framing matches on specified value
3 participants