Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskAttributionTiming[] syntax is not valid Web IDL #9

Closed
domenic opened this issue Jan 13, 2017 · 3 comments
Closed

TaskAttributionTiming[] syntax is not valid Web IDL #9

domenic opened this issue Jan 13, 2017 · 3 comments
Milestone

Comments

@domenic
Copy link
Contributor

domenic commented Jan 13, 2017

Some older specs use this construct, but it's not good. I think you want FrozenArray<TaskAttributionTiming>

@spanicker
Copy link
Contributor

@igrigorik
Other performance types use sequence, should we deviate here?

@domenic
Copy link
Contributor Author

domenic commented Jan 13, 2017

Note that per https://heycam.github.io/webidl/#idl-attributes it is impossible for the type of an attribute to be a sequence type... ("The type of the attribute, after resolving typedefs, must not be a nullable or non-nullable version of any of the following types:")

So yeah, I think deviating is the right thing to do, and preferably fixing the other performance specs so that they are implementable in browsers like Firefox that have a strict Web IDL parser.

@igrigorik igrigorik added this to the Level 1 milestone Jul 21, 2017
@spanicker
Copy link
Contributor

already updated to FrozenArray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants